Skip to content

Commit

Permalink
feat: allow post npm build patch in Dockerfile
Browse files Browse the repository at this point in the history
Close #167
  • Loading branch information
Danyal-Faheem authored and regisb committed Dec 8, 2023
1 parent 7f2a04f commit aa62ada
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Feature] Added patch to allow changes to Dockerfile after the npm build has completed. (by @Danyal-Faheem)
2 changes: 2 additions & 0 deletions tutormfe/templates/mfe/build/mfe/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ CMD ["/bin/bash", "-c", "npm run start --- --config ./webpack.dev-tutor.config.j
FROM {{ app_name }}-common AS {{ app_name }}-prod
ENV NODE_ENV=production
RUN npm run build
{{ patch("mfe-dockerfile-post-npm-build") }}
{{ patch("mfe-dockerfile-post-npm-build-{}".format(app_name)) }}
{% endfor %}

####### final production image with all static assets
Expand Down

0 comments on commit aa62ada

Please sign in to comment.