feat: introduces MFE_DOCKER_IMAGE_DEV_PREFIX (#216)

overhangio · Jul 1, 2024 · eab8bba · eab8bba
1 parent d95de70
commit eab8bba
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/changelog.d/20240621_123709_rediris_customize_dev_docker_image_tag.md b/changelog.d/20240621_123709_rediris_customize_dev_docker_image_tag.md
@@ -0,0 +1 @@
+- [Feature] Introduce a `MFE_DOCKER_IMAGE_DEV_PREFIX` setting to customize dev MFE image docker repos. (by @rediris)
diff --git a/tutormfe/patches/local-docker-compose-dev-services b/tutormfe/patches/local-docker-compose-dev-services
@@ -10,7 +10,7 @@ mfe:
 {%- set mounts = iter_mounts(MOUNTS, app_name)|list %}
 {%- if mounts %}
 {{ app_name }}: # Work on this MFE for development
-    image: "{{ DOCKER_REGISTRY }}overhangio/openedx-{{ app_name }}-dev:{{ MFE_VERSION }}"
+    image: "{{ MFE_DOCKER_IMAGE_DEV_PREFIX }}-{{ app_name }}-dev:{{ MFE_VERSION }}"
     ports:
         - "{{ app["port"] }}:{{ app["port"] }}"
     stdin_open: true

diff --git a/tutormfe/plugin.py b/tutormfe/plugin.py
@@ -23,6 +23,7 @@
     "defaults": {
         "VERSION": __version__,
         "DOCKER_IMAGE": "{{ DOCKER_REGISTRY }}overhangio/openedx-mfe:{{ MFE_VERSION }}",
+        "DOCKER_IMAGE_DEV_PREFIX": "{{ DOCKER_REGISTRY }}overhangio/openedx",
         "HOST": "apps.{{ LMS_HOST }}",
         "COMMON_VERSION": "{{ OPENEDX_COMMON_VERSION }}",
         "CADDY_DOCKER_IMAGE": "{{ DOCKER_IMAGE_CADDY }}",
@@ -152,7 +153,7 @@ def get_mfe(mfe_name: str) -> MFE_ATTRS_TYPE:
 def _mounted_mfe_image_management() -> None:
     for mfe_name, _mfe_attrs in iter_mfes():
         name = f"{mfe_name}-dev"
-        tag = "{{ DOCKER_REGISTRY }}overhangio/openedx-" + name + ":{{ MFE_VERSION }}"
+        tag = "{{ MFE_DOCKER_IMAGE_DEV_PREFIX }}-" + name + ":{{ MFE_VERSION }}"
         tutor_hooks.Filters.IMAGES_BUILD.add_item(
             (
                 name,