Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify port for dev server to listen on #172

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

michaelwheeler
Copy link
Contributor

Seems like the PORT environment variable was removed at some point after v14.0.2. This left development containers listening at the default port 8080, which is not forwarded to the host.

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a changelog entry with scriv create?

@michaelwheeler
Copy link
Contributor Author

Can you please add a changelog entry with scriv create?

Should be all set.

@regisb regisb merged commit f48c747 into overhangio:master Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants