Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto-build mfe image in nightly #175

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: auto-build mfe image in nightly #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/20231208_112710_regis_nightly_auto_build_mfe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Bugfix] Auto-build "mfe" image during `dev/local launch` in nightly. (by @regisb)
4 changes: 4 additions & 0 deletions tutormfe/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,10 @@ def _print_mfe_public_hosts(
def _build_3rd_party_dev_mfes_on_launch(
image_names: list[str], context_name: t.Literal["local", "dev"]
) -> list[str]:
if __version_suffix__:
# Build mfe image in nightly mode
image_names.append("mfe")

for mfe_name, _mfe_attrs in iter_mfes():
if __version_suffix__ or (
context_name == "dev" and mfe_name not in CORE_MFE_APPS
Expand Down
Loading