feat: faster init by avoiding repeated waffle flag listing #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DawoudSheraz
approved these changes
Jul 30, 2024
rediris
approved these changes
Aug 2, 2024
Calling `./manage.py lms waffle_flag --list` so many times causes the MFE initialisation step to take a very long time, because `./manage.py lms` is very slow. We avoid this by listing existing waffle flags in a temporary file. On an already initialized system, `tutor local do init --limit=mfe` drops from 3min 27s to 25s.
regisb
force-pushed
the
regisb/faster-init
branch
from
62b27a5
to
c19301e
Compare
|
I have added some stats to the git message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
./manage.py lms waffle_flag --listso many times causes the MFE initialisation step to take a very long time, because./manage.py lmsis very slow. We avoid this by listing existing waffle flags in a temporary file.On an already initialized system,
tutor local do init --limit=mfedrops from 3min 27s to 25s.