Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add account mfe patch to show account page #221

Closed
wants to merge 2 commits into from
Closed

fix: add account mfe patch to show account page #221

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49cfd0f
fix: add account mfe patch to show account page
hinakhadim Aug 20, 2024
9fbdae3
chore: update changelog
hinakhadim Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/20240820_112614_hina.khadim_account_mfe_patch.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [BugFix] Add upstream footer-slot patch in account-mfe (by @hinakhadim)
Copy link
Contributor

@DawoudSheraz DawoudSheraz Aug 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changelog needs some details, the current description is not enough to explain the underlying issue

4 changes: 4 additions & 0 deletions tutormfe/patches/mfe-dockerfile-pre-npm-build-account
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
RUN git config --global user.email "[email protected]" \
&& git config --global user.name "Tutor"
hinakhadim marked this conversation as resolved.
Show resolved Hide resolved

RUN curl -fsSL https://github.com/openedx/frontend-app-account/commit/16fb3a1bb4c00d2b60ec3686001814461437e3a5.patch | git am