fix: add PROFILE_IMAGE_BACKEND settings for k8s #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faraz32123
force-pushed
the
fix/add_profile_image_backend_for_k8s_deployment
branch
from
268de10
to
68b3c12
Compare
Faraz32123
force-pushed
the
fix/add_profile_image_backend_for_k8s_deployment
branch
2 times, most recently
from
13410d8
to
d0bb7c4
Compare
|
Profile image is now working! This PR is tested with both local and dev environment and with K8s environment as well. |
regisb
approved these changes
Oct 30, 2024
DawoudSheraz
approved these changes
Oct 31, 2024
- Add PROFILE_IMAGE_BACKEND settings in tutor-minio using patch named `openedx-lms-production-settings` so that profile images persist in k8s deployment of openedx and profile images can work now for both local(will use minio storage if minio plugin is enabled) and dev environment. - In case of dev environment, backend expects the valid S3 `base_url` key in the PROFILE_IMAGE_BACKEND settings. It will be using openedx `DEFAULT_FILE_STORAGE`.
Faraz32123
force-pushed
the
fix/add_profile_image_backend_for_k8s_deployment
branch
from
d0bb7c4
to
15efa14
Compare
Faraz32123
deleted the
fix/add_profile_image_backend_for_k8s_deployment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openedx-lms-production-settingsso that profile images persistin k8s deployment of openedx and profile images can work now for both
local(will use minio storage if minio plugin is enabled) and dev environment.
base_urlkey in the PROFILE_IMAGE_BACKEND settings. It will be using openedx
DEFAULT_FILE_STORAGE.