feat: upgrade to Quince #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is due to quickstart being renamed to launch in tutor.
This is to address overhangio/tutor-mfe#122 As a consequence of this change, images will be tagged with a "-nightly" suffix. Next, we'll probably have to build them periodically in CI.
The package version number may not include the "-nightly" suffix. Otherwise, installation fails with: setuptools.extern.packaging.version.InvalidVersion: Invalid version: '15.0.7-nightly'
regisb
reviewed
Nov 16, 2023
Build fails in nightly with the following error: #28 5.503 × Getting requirements to build wheel did not run successfully. #28 5.503 │ exit code: 1 #28 5.503 ╰─> [24 lines of output] #28 5.503 /bin/sh: 1: pkg-config: not found #28 5.503 /bin/sh: 1: pkg-config: not found #28 5.503 Trying pkg-config --exists mysqlclient #28 5.503 Command 'pkg-config --exists mysqlclient' returned non-zero exit status 127. #28 5.503 Trying pkg-config --exists mariadb #28 5.503 Command 'pkg-config --exists mariadb' returned non-zero exit status 127. #28 5.503 Traceback (most recent call last): #28 5.503 File "/openedx/venv/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 353, in <module> #28 5.503 main() #28 5.503 File "/openedx/venv/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 335, in main #28 5.503 json_out['return_val'] = hook(**hook_input['kwargs']) #28 5.503 File "/openedx/venv/lib/python3.8/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 118, in get_requires_for_build_wheel #28 5.503 return hook(config_settings) #28 5.503 File "/tmp/pip-build-env-58chejnv/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 355, in get_requires_for_build_wheel #28 5.503 return self._get_build_requires(config_settings, requirements=['wheel']) #28 5.503 File "/tmp/pip-build-env-58chejnv/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 325, in _get_build_requires #28 5.503 self.run_setup() #28 5.503 File "/tmp/pip-build-env-58chejnv/overlay/lib/python3.8/site-packages/setuptools/build_meta.py", line 341, in run_setup #28 5.503 exec(code, locals()) #28 5.503 File "<string>", line 154, in <module> #28 5.503 File "<string>", line 48, in get_config_posix #28 5.503 File "<string>", line 27, in find_package_name #28 5.503 Exception: Can not find valid pkg-config name. #28 5.503 Specify MYSQLCLIENT_CFLAGS and MYSQLCLIENT_LDFLAGS env vars manuallY
|
Yes :) |
By pulling the version suffix from tutor, we avoid git conflicts when merging the release branch in nightly.
This is related to overhangio/tutor#945
regisb
force-pushed
the
quince
branch
2 times, most recently
from
84e3f2b
to
c650a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #22