Skip to content

Commit

Permalink
feat: skip explicit openedx-dev image building in tutor dev launch
Browse files Browse the repository at this point in the history
I have no idea why we decided to kickstart a separate build. The image will be
built anyway at the next step because we run `docker compose up --build` in
`tutor dev start`.

The build step was introduced in this PR: #627
  • Loading branch information
regisb committed Dec 13, 2022
1 parent c70a6a5 commit 146ec62
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions changelog.d/20221213_090356_regis_dev.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Improvement] Skip unnecessary image building in development. This should make `tutor dev launch` slightly faster. (by @regisb)
3 changes: 0 additions & 3 deletions tutor/commands/dev.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,6 @@ def launch(
click.echo(fmt.title("Docker image updates"))
context.invoke(compose.dc_command, command="pull")

click.echo(fmt.title("Building Docker image for LMS and CMS development"))
context.invoke(compose.dc_command, command="build", args=["lms"])

click.echo(fmt.title("Starting the platform in detached mode"))
context.invoke(compose.start, detach=True)

Expand Down

0 comments on commit 146ec62

Please sign in to comment.