Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: using patches instead of patchesStrategicMerge #947

Merged
merged 1 commit into from
Nov 24, 2023
Merged

feat: using patches instead of patchesStrategicMerge #947

merged 1 commit into from
Nov 24, 2023

Conversation

jfavellar90
Copy link

This PR fixes #941

@jfavellar90 jfavellar90 marked this pull request as draft November 24, 2023 01:14
@jfavellar90
feat: using patches instead of patchesStrategicMerge
ecc8089 
[patchesStrategicMerge](https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/patchesstrategicmerge/) is going to be deprecated in future releases of the Kustomization API. It is replaced by the [patches](https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/patches/) key which is more powerful and allows defining different patch types
@jfavellar90 jfavellar90 force-pushed the Jhony/kustomize_patches_migration branch from 2f492d6 to ecc8089 Compare November 24, 2023 01:58
@jfavellar90 jfavellar90 marked this pull request as ready for review November 24, 2023 01:59
@jfavellar90
Copy link
Author

jfavellar90 commented Nov 24, 2023 •
edited
Loading

  • Adding a meaningful commit message
  • Adding a Changelog entry
  • Make the tests pass

@regisb regisb changed the base branch from quince to nightly November 24, 2023 07:58
@regisb regisb changed the base branch from nightly to quince November 24, 2023 07:58
regisb
regisb approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect on the first try :)

@regisb regisb merged commit 74cc956 into overhangio:quince Nov 24, 2023
@regisb regisb mentioned this pull request Nov 24, 2023
Open
@jfavellar90 jfavellar90 mentioned this pull request Nov 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisb regisb regisb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfavellar90 @regisb