SNAP App: support for Thumbstick of the right controller to capture picture and gif in HMD only. #1090
Conversation
This adds the possibility to click on the Thumbstick of the right controller to capture picture and gif, for HMD only.
ksuprynowicz
added
the
CR approved
|
I think this PR is safe to merge |
| } | ||
| return; | ||
| }); | ||
| } |
There was a problem hiding this comment.
There should be some sort of fallback for an unrecognized controller. At least log something, so that there's some clue as to what is wrong, but preferably an user-visible error message.
Also, the XBox controller has been used for VR, so it's also a possibility.
There was a problem hiding this comment.
3 things about it...
1- Fact: I simply bring the code from other camera app supporting the right thumb stick. This means that the same issue exists in those app too.
2- Xbox Controller: I don't have the hardware so I wouldn't be able to test it. I have honestly not consider support larger than that for that simple reason. If you have the "controllerType" string and which Controller.Standard.### it uses, then yes, I can add it.
3- Unrecognized controller: Currently, if a controller is not recognized, it simply do nothing. (No error, just not supported). The existence of this feature is not even written anywhere. This is not on the UI (a bit intentional). So people are currently find out accidentally or by learning from someone else. If a user has an unsupported controller, it won't tell him that the feature that he has never heard about before, is not working for him. He will be then as happy as all of us before this new implementation. In my opinion, It would be a bit mistake to advise directly the user that his controller is not taking change of this feature. It just cause the deception even before the need appears... It will just look clunkier as system for that user after that.
Instead, I would add a notice in the UI, but only if the controller is supporting it.
I didn't went there cause the cost in time was a bit too much for actually just a "shortcut".
Which means: changes in the Ui and what it needs between the app and the UI to hide/show the notice.
I can do it. Let me know what you think about this approach.
|
I tested this on desktop on Linux, both with and without a controller. Works fine in the sense that nothing breaks. |
This PR adds the possibility to click on the thumbstick of the right controller to capture picture and gif, for HMD only.
It was a bit an irritant to capture picture and have to click on the tablet to do it. It is annoying for the posture if you are in the photo and it was quite a limitation to capture in movement.
It supports at least Vive and Oculus Touch.