Fix selfie mode movement #1127
Open
Fix selfie mode movement #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Armored-Dragon
added
needs CR
|
Oh a whole file format managed to slip by me. I will look at that soon. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Maybe it was using different newline characters? |
This comment was marked as outdated.
This comment was marked as outdated.
|
I got it. |
HifiExperiments
approved these changes
Sep 9, 2024
HifiExperiments
added
CR approved
Co-authored-by: HifiExperiments <[email protected]>
|
I had just noticed that mouse look is also inverted while in selfie mode. I just snuck in the fix with this pull. |
HifiExperiments
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Selfie mode (View 2 on the keyboard) if you were to press either "A" or "D" keys with the intention of moving your character, your avatar will be moving in a unexpected way.
This pull adds an additional check to see if the user is in "Selfie Mode" and will move the character in the expected direction.
In effect, this mirrors the current movement direction. So in Selfie Mode you will be moving to the left in the perspective of your character when you press the "D" key.
Fixes #821
Closes #135. Unless I am misreading this issue, this would have been a problem solved a long while ago. What is described is not what I observe.