Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix accidentally clearing url fields when you don't have view permission #1138

Merged
merged 1 commit into from
Sep 22, 2024
Merged

fix accidentally clearing url fields when you don't have view permission #1138

merged 1 commit into from
Sep 22, 2024

Conversation

HifiExperiments
Copy link
Member

fixes #1130

@HifiExperiments HifiExperiments added bug Something isn't working needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested labels Sep 9, 2024
Armored-Dragon
Armored-Dragon approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@Armored-Dragon Armored-Dragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take a mogging instead of being assigned edit.js any day of the week.
Everything looks good.
Lightly tested. I can not create servers this instant to put myself in this permission position, however the code provided does not break anything.
Thank you!

@Armored-Dragon Armored-Dragon added CR approved This pull request has been successfully code reviewed and removed needs CR This pull request needs to be code reviewed labels Sep 9, 2024
ksuprynowicz
ksuprynowicz approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@ksuprynowicz ksuprynowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine :)

@ksuprynowicz ksuprynowicz added QA approved This pull request has been successfully tested and removed needs QA This pull request needs to be tested labels Sep 22, 2024
@ksuprynowicz ksuprynowicz merged commit 542b231 into overte-org:master Sep 22, 2024
9 checks passed
@HifiExperiments HifiExperiments deleted the emptyField branch September 22, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Armored-Dragon Armored-Dragon Armored-Dragon approved these changes

@ksuprynowicz ksuprynowicz ksuprynowicz approved these changes

Assignees
No one assigned
Labels
bug Something isn't working CR approved This pull request has been successfully code reviewed QA approved This pull request has been successfully tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create App: “permission to view URL” empties fields
3 participants
@HifiExperiments @ksuprynowicz @Armored-Dragon