Test Conan GitHub Actions #1300
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianGro
added
server
Currently can only build the interface
This way we can continue to override CGLTF_ATOF to fix floating point conversion issues on systems with `,` decimal separators.
This still fails as upstream Qt includes an old bug in qtlocation/src/3rdparty/mapbox-gl-native/include/mbgl/util/geometry.hpp; We should switch to KDE's Qt patchset as it has issues like this patched and we already use it on VCPKG. (https://invent.kde.org/qt/qt/qt5/-/tree/kde/5.15)
Looking at the code, it was always pretty hacky and more or less worked coincidentally. So for now, the "fix" is also a hack.
As the previous code, this is pretty hacky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.