feat(dedicated): delete vrack from billing autorenew page #13823
+244
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhelhali-soufien
requested review from
antonymarion,
MaximeBajeux and
anooparveti
github-actions
bot
added
universe-bare-metal-cloud
translation required
common
feature
mhelhali-soufien
requested review from
qpavy and
sachinrameshn
and removed request for
antonymarion,
MaximeBajeux and
anooparveti
mhelhali-soufien
force-pushed
the
feat/MANAGER-15077
branch
from
31a46e4 to
569c062
Compare
| /* @ngInject */ | ||
| constructor($scope, $translate, BillingTerminate, OvhApiVrack) { | ||
| this.$scope = $scope; | ||
| this.TERMINATE_PATTERN = /^TERMINATE$/; |
There was a problem hiding this comment.
Its good to keep this in constant file
qpavy
requested changes
Nov 6, 2024
Comment on lines
14
to
28
| this.OvhApiVrack.Aapi() | ||
| .services({ serviceName: this.service }) | ||
| .$promise.then((allServicesParam) => { | ||
| const services = Object.entries(allServicesParam).filter( | ||
| ([, value]) => { | ||
| return Array.isArray(value) && value.length; | ||
| }, | ||
| ); | ||
| if (!services.length) { | ||
| this.$scope.isEmpty = true; | ||
| } | ||
| }) | ||
| .finally(() => { | ||
| this.$scope.isLoading = false; | ||
| }); |
There was a problem hiding this comment.
This can be done on routing resolve so it is executed before page load
| bindings: { | ||
| goBack: '<', | ||
| service: '<', | ||
| serviceType: '<', |
There was a problem hiding this comment.
Suggested change
| serviceType: '<', | |
| serviceType: '<', | |
| isEmpty: '<' |
packages/manager/modules/billing/src/autoRenew/actions/terminate-vrack/routing.js
Show resolved
Hide resolved
|
sachinrameshn
requested changes
Nov 13, 2024
| export default class TerminateVrackController { | ||
| /* @ngInject */ | ||
| constructor($scope, $translate, BillingTerminate) { | ||
| this.$scope = $scope; |
qpavy
requested changes
Nov 14, 2024
Comment on lines
15
to
17
| isEmpty: /* @ngInject */ (OvhApiVrack, $transition$) => | ||
| OvhApiVrack.Aapi() | ||
| .services({ serviceName: $transition$.params().service }) |
There was a problem hiding this comment.
Suggested change
| isEmpty: /* @ngInject */ (OvhApiVrack, $transition$) => | |
| OvhApiVrack.Aapi() | |
| .services({ serviceName: $transition$.params().service }) | |
| isEmpty: /* @ngInject */ (OvhApiVrack, service) => | |
| OvhApiVrack.Aapi() | |
| .services({ serviceName: service }) |
qpavy
previously approved these changes
Nov 15, 2024
sachinrameshn
previously approved these changes
Nov 15, 2024
github-actions
bot
added
the
has conflicts
added 3 commits
January 2, 2025 15:10
ref: MANAGER-15077 Signed-off-by: soufien mhelhali <[email protected]>
mhelhali-soufien
dismissed stale reviews from sachinrameshn and qpavy
via
8f68197
mhelhali-soufien
force-pushed
the
feat/MANAGER-15077
branch
from
289f616 to
8f68197
Compare
github-actions
bot
removed
the
has conflicts
Signed-off-by: CDS Translator Agent <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
masterDescription
Related
translation