Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dedicated,vps): margin issues around sshkey component #14010

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(dedicated,vps): margin issues around sshkey component #14010

wants to merge 2 commits into from
+15 −21

Conversation

JayBeeDe
Copy link
Member

@JayBeeDe JayBeeDe commented Nov 7, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix MANAGER-15969 (1 of 2)
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)

Description

Fix french translation typo and minor margin issues around sshKey component

Related

fix(manager-components): ssh-key-selector margin issues by JayBeeDe · Pull Request #14245 · ovh/manager

@JayBeeDe JayBeeDe requested a review from a team as a code owner November 7, 2024 17:03
anooparveti
anooparveti reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Why do you want to also update Messages_fr_CA.json?

@JayBeeDe
Copy link
Member Author

JayBeeDe commented Nov 20, 2024 •
edited
Loading

Question: Why do you want to also update Messages_fr_CA.json?

Because translation issue is only in french language, other languages are fine

qpavy
qpavy previously approved these changes Nov 21, 2024
View reviewed changes
@sachinrameshn sachinrameshn self-requested a review November 21, 2024 08:21
sachinrameshn
sachinrameshn reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@sachinrameshn sachinrameshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JayBeeDe ,
Can you please split the changes on manager-components into separate PR ?

This will help us to gain some time during the release.
Need is:
Just create another PR with the changes on manager-components and target develop.

@sachinrameshn sachinrameshn self-requested a review November 21, 2024 08:25
sachinrameshn
sachinrameshn requested changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@sachinrameshn sachinrameshn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @JayBeeDe ,
Can you please split the changes on manager-components into separate PR ?

This will help us to gain some time during the release.
Need is:
Just create another PR with the changes on manager-components and target develop.

@JayBeeDe JayBeeDe dismissed stale reviews from mhelhali-soufien and qpavy via 143647c November 25, 2024 11:01
@JayBeeDe JayBeeDe changed the title Fix/manager 15969 fix(dedicated,vps): margin issues around sshkey component Nov 25, 2024
@JayBeeDe JayBeeDe mentioned this pull request Nov 25, 2024
Merged
6 tasks
@JayBeeDe
Copy link
Member Author

Hello @JayBeeDe , Can you please split the changes on manager-components into separate PR ?

This will help us to gain some time during the release. Need is: Just create another PR with the changes on manager-components and target develop.

fix(manager-components): ssh-key-selector margin issues by JayBeeDe · Pull Request #14245 · ovh/manager

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

@github-actions github-actions bot added the stale No activity since a long time label Jan 3, 2025
@JayBeeDe JayBeeDe removed the stale No activity since a long time label Jan 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

This Pull Request is stale due to inactivity since 30 days. If no activity happens for 15 more days from now, it will be closed.

@github-actions github-actions bot added the stale No activity since a long time label Feb 3, 2025
@JayBeeDe JayBeeDe removed the stale No activity since a long time label Feb 3, 2025
@JayBeeDe
fix(dedicated): french translation typo
b44f13b 
ref: MANAGER-15969
Signed-off-by: Jean-Baptiste Delon <[email protected]>
@JayBeeDe
fix(dedicated,vps): margin issues around sshkey component
b7f873c 
ref: MANAGER-15969
Signed-off-by: Jean-Baptiste Delon <[email protected]>
@JayBeeDe JayBeeDe requested review from a team as code owners February 26, 2025 09:59
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti left review comments

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux was automatically assigned from ovh/team-manager-dev-angularjs

@tristanwagner tristanwagner Awaiting requested review from tristanwagner tristanwagner is a code owner automatically assigned from ovh/dev-manager-web-all

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/dev-manager-web-all

@stif59100 stif59100 Awaiting requested review from stif59100 stif59100 is a code owner automatically assigned from ovh/dev-manager-web-all

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/dev-manager-infra-all

@chipp972 chipp972 Awaiting requested review from chipp972 chipp972 is a code owner automatically assigned from ovh/dev-manager-infra-all

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/dev-manager-infra-all

@pauldkn pauldkn Awaiting requested review from pauldkn pauldkn is a code owner automatically assigned from ovh/dev-manager-hpc-all

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/dev-manager-hpc-all

@vovh vovh Awaiting requested review from vovh vovh is a code owner automatically assigned from ovh/dev-manager-hpc-all

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JayBeeDe @qpavy @anooparveti @sachinrameshn @mhelhali-soufien