Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pci kubernetes test tapc 1400 #14295

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from
Open

Feat/pci kubernetes test tapc 1400 #14295

wants to merge 10 commits into from
+184 −16

Conversation

ppprevost
Copy link
Contributor

Question Answer
Branch? master / release/** / develop
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

Pierre-Philippe added 6 commits November 25, 2024 16:16
feat(pci.rancher): add driver error
0b7ddf4 
ref: TAPC-1400
Signed-off-by: Pierre-Philippe <[email protected]>
fix(i18n): add missing translations [CDS 138]
dd6300d 
Signed-off-by: CDS Translator Agent <[email protected]>
feat(pci.rancher): update sonar
a3db119 
ref: TAPC-1400
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci.rancher): fix sonar
2d0f225 
ref: TAPC-1400
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci.rancher): fix date display
15f60ea 
ref: TAPC-1400
Signed-off-by: Pierre-Philippe <[email protected]>
feat(pci.kubernetes): test
5461847 
ref: TAPC-1400
Signed-off-by: Pierre-Philippe <[email protected]>
@ppprevost ppprevost requested review from a team as code owners November 27, 2024 10:02
@github-actions github-actions bot added translation required universe-public-cloud feature New feature has conflicts Has conflicts to resolve before merging labels Nov 27, 2024
@SimonChaumet SimonChaumet added the blocked Don't merge yet label Nov 27, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked Don't merge yet feature New feature has conflicts Has conflicts to resolve before merging translation required universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppprevost @SimonChaumet