Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common-api-module): create a common-api module #14301

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chipp972
Copy link
Contributor

ref: MANAGER-15700

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-15700
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

  • common-api module to share code and types around api management and requests
  • test-utils core module to share code and types around testing with vitest and creating mocks

Related

@chipp972 chipp972 requested review from a team as code owners November 27, 2024 11:10
@github-actions github-actions bot added continuous-integration Changes to our CI configuration files and scripts dependencies Pull requests that update a dependency file common feature New feature labels Nov 27, 2024
Copy link
Contributor

yarn.lock changes

Summary

Status Count
UPDATED 16
Click to toggle table visibility
Name Status Previous Current
@orchidjs/sifter UPDATED 1.0.3 1.1.0
@orchidjs/unicode-variants UPDATED 1.0.4 1.1.2
@testing-library/jest-dom UPDATED 6.5.0 6.6.3
@vitejs/plugin-react UPDATED 4.3.2 4.3.3
@vitest/coverage-v8 UPDATED 2.1.4 2.1.5
@vitest/expect UPDATED 2.1.4 2.1.5
@vitest/mocker UPDATED 2.1.4 2.1.5
@vitest/pretty-format UPDATED 2.1.4 2.1.5
@vitest/runner UPDATED 2.1.4 2.1.5
@vitest/snapshot UPDATED 2.1.4 2.1.5
@vitest/spy UPDATED 2.1.4 2.1.5
@vitest/utils UPDATED 2.1.4 2.1.5
es-module-lexer UPDATED 1.5.0 1.5.4
std-env UPDATED 3.7.0 3.8.0
vite-node UPDATED 2.1.4 2.1.5
vitest UPDATED 2.1.4 2.1.5

tibs245
tibs245 previously approved these changes Nov 27, 2024
ref: MANAGER-15700

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Copy link

sonarcloud bot commented Nov 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
48.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common continuous-integration Changes to our CI configuration files and scripts dependencies Pull requests that update a dependency file feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants