Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-object-storage): download user policy json #14305

Merged
merged 2 commits into from
Nov 29, 2024
Merged

feat(pci-object-storage): download user policy json #14305

merged 2 commits into from
Nov 29, 2024

Conversation

seven-amid
Copy link
Contributor

ref: DTCORE-2880

  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@seven-amid seven-amid requested review from a team as code owners November 27, 2024 14:54
@seven-amid seven-amid requested review from sidlynx, kqesar, qpavy, anooparveti and sachinrameshn and removed request for a team November 27, 2024 14:54
@github-actions github-actions bot added feature New feature has conflicts Has conflicts to resolve before merging labels Nov 27, 2024
@seven-amid seven-amid force-pushed the feat/DTCORE-2880 branch 2 times, most recently from a52511a to 3b9ed1a Compare November 28, 2024 10:46
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 28, 2024
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 29, 2024
@seven-amid
feat(pci-object-storage): download user policy json
243ac09 
ref: DTCORE-2880
Signed-off-by: LIDRISSI Hamid <[email protected]>
@seven-amid
feat(pci-object-storage): show S3 secret
ec4beee 
ref: DTCORE-2882
Signed-off-by: LIDRISSI Hamid <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@seven-amid seven-amid merged commit f6c02bb into feat/pci-object-storage Nov 29, 2024
12 of 13 checks passed
@seven-amid seven-amid deleted the feat/DTCORE-2880 branch November 29, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidlynx sidlynx sidlynx approved these changes

@kqesar kqesar kqesar approved these changes

@frenautvh frenautvh frenautvh approved these changes

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seven-amid @sidlynx @kqesar @frenautvh