Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(instance): replace savings plan banner on edition instance #14306

Merged
merged 2 commits into from
Jan 10, 2025
Merged

feat(instance): replace savings plan banner on edition instance #14306

merged 2 commits into from
Jan 10, 2025

Conversation

lionel95200x
Copy link
Contributor

ref:TAPC-2108

Question Answer
Branch? master
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #TAPC-2108
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Replace savings plan banner on edition instance

Related

@lionel95200x lionel95200x requested a review from a team as a code owner November 27, 2024 14:54
@lionel95200x lionel95200x force-pushed the feat/TAPC-2108-instance-edit branch 4 times, most recently from da2d207 to a074fcc Compare December 10, 2024 13:53
@github-actions github-actions bot added translation required has conflicts Has conflicts to resolve before merging labels Jan 8, 2025
Lionel Bueno added 2 commits January 8, 2025 15:41
@lionel95200x lionel95200x force-pushed the feat/TAPC-2108-instance-edit branch from 0a46f94 to a5abf87 Compare January 8, 2025 14:44
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Jan 8, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anooparveti anooparveti changed the base branch from develop to release/public-cloud-w3 January 10, 2025 06:02
@anooparveti anooparveti merged commit e3998e6 into release/public-cloud-w3 Jan 10, 2025
17 of 18 checks passed
@anooparveti anooparveti deleted the feat/TAPC-2108-instance-edit branch January 10, 2025 06:03
@anooparveti anooparveti mentioned this pull request Jan 10, 2025
Merged
2 tasks
anooparveti pushed a commit that referenced this pull request Jan 15, 2025
@lionel95200x @anooparveti
feat(pci): replace savings plan banner on edition instance (#14306)
7a72d13 
ref:TAPC-2108

Signed-off-by: Lionel Bueno <[email protected]>
aottr pushed a commit that referenced this pull request Jan 21, 2025
@lionel95200x @aottr
feat(pci): replace savings plan banner on edition instance (#14306)
f768533 
ref:TAPC-2108

Signed-off-by: Lionel Bueno <[email protected]>
hbelkhir pushed a commit that referenced this pull request Jan 21, 2025
@lionel95200x @hbelkhir
feat(pci): replace savings plan banner on edition instance (#14306)
c983a00 
ref:TAPC-2108

Signed-off-by: Lionel Bueno <[email protected]>
aboungnaseng-ovhcloud pushed a commit that referenced this pull request Jan 21, 2025
@lionel95200x @aboungnaseng-ovhcloud
feat(pci): replace savings plan banner on edition instance (#14306)
021ec81 
ref:TAPC-2108

Signed-off-by: Lionel Bueno <[email protected]>
hbelkhir pushed a commit that referenced this pull request Jan 24, 2025
@lionel95200x @hbelkhir
feat(pci): replace savings plan banner on edition instance (#14306)
6b9e260 
ref:TAPC-2108

Signed-off-by: Lionel Bueno <[email protected]>
aottr pushed a commit that referenced this pull request Feb 20, 2025
@lionel95200x @aottr
feat(pci): replace savings plan banner on edition instance (#14306)
5d6950c 
ref:TAPC-2108

Signed-off-by: Lionel Bueno <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anooparveti anooparveti anooparveti approved these changes

@Eric-ciccotti Eric-ciccotti Eric-ciccotti approved these changes

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion was automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

@mhelhali-soufien mhelhali-soufien Awaiting requested review from mhelhali-soufien mhelhali-soufien was automatically assigned from ovh/team-manager-dev-angularjs

@tristanwagner tristanwagner Awaiting requested review from tristanwagner

Assignees
No one assigned
Labels
feature New feature quality check: ok universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lionel95200x @tristanwagner @anooparveti @Eric-ciccotti @fredericvilcot