Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vcd): rework translations structure and constant labels #14318

Merged
merged 2 commits into from
Dec 12, 2024
Merged

feat(vcd): rework translations structure and constant labels #14318

merged 2 commits into from
Dec 12, 2024

Conversation

pauldkn
Copy link
Contributor

@pauldkn pauldkn commented Nov 27, 2024

ref: MANAGER-15996

Question Answer
Branch? feat/vcd-veeam-postga
Bug fix? no
New feature? yes
Breaking change? no
Tickets feat/MANAGER-15996
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@pauldkn pauldkn requested review from a team as code owners November 27, 2024 18:29
@pauldkn pauldkn requested review from frenautvh, seven-amid, qpavy, anooparveti and sachinrameshn and removed request for a team November 27, 2024 18:29
@pauldkn pauldkn force-pushed the feat/MANAGER-15996 branch 2 times, most recently from ecf0d8f to 79e0aa9 Compare November 28, 2024 09:02
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Nov 28, 2024
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Nov 28, 2024
@pauldkn pauldkn force-pushed the feat/MANAGER-15996 branch 3 times, most recently from b75486f to cdedc24 Compare November 28, 2024 16:29
@pauldkn pauldkn force-pushed the feat/vcd-veeam-postga branch from f60f6c8 to 5d09aa0 Compare December 2, 2024 10:47
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 2, 2024
@pauldkn pauldkn force-pushed the feat/MANAGER-15996 branch from cdedc24 to 1f6cb8f Compare December 2, 2024 11:20
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 2, 2024
@chipp972 chipp972 force-pushed the feat/vcd-veeam-postga branch from 4638950 to 1c4d358 Compare December 3, 2024 16:54
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 3, 2024
@pauldkn pauldkn force-pushed the feat/MANAGER-15996 branch from 1f6cb8f to a1ff82a Compare December 9, 2024 10:16
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 9, 2024
@chipp972 chipp972 force-pushed the feat/vcd-veeam-postga branch from 003badd to 5ef2ab7 Compare December 9, 2024 10:36
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 9, 2024
@pauldkn pauldkn force-pushed the feat/MANAGER-15996 branch from a1ff82a to 0b09734 Compare December 9, 2024 15:09
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 9, 2024
@chipp972 chipp972 force-pushed the feat/vcd-veeam-postga branch from 99b4f10 to e6ebbe3 Compare December 9, 2024 15:41
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 9, 2024
@pauldkn pauldkn force-pushed the feat/MANAGER-15996 branch from 0b09734 to 7e3ab9e Compare December 9, 2024 16:57
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 9, 2024
@chipp972 chipp972 force-pushed the feat/vcd-veeam-postga branch from c9f36e3 to 53a7947 Compare December 11, 2024 13:46
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 11, 2024
Paul Dickerson added 2 commits December 12, 2024 09:44
feat(vcd): rework translations structure and constant labels
663c693 
ref: MANAGER-15996

Signed-off-by: Paul Dickerson <[email protected]>
feat(vcd): fix filenames cases according to guidelines
e4115fb 
ref: MANAGER-15996

Signed-off-by: Paul Dickerson <[email protected]>
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 12, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@pauldkn pauldkn merged commit b27094d into feat/vcd-veeam-postga Dec 12, 2024
14 checks passed
@pauldkn pauldkn deleted the feat/MANAGER-15996 branch December 12, 2024 09:35
chipp972 pushed a commit that referenced this pull request Dec 12, 2024
@pauldkn
feat(vcd): rework translations structure and constant labels (#14318)
6e2c307 
* feat(vcd): rework translations structure and constant labels

desc: update file structure and standardize filenames
ref: MANAGER-15996

Signed-off-by: Paul Dickerson <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>
chipp972 pushed a commit that referenced this pull request Dec 13, 2024
@pauldkn
feat(vcd): rework translations structure and constant labels (#14318)
63195c5 
* feat(vcd): rework translations structure and constant labels

desc: update file structure and standardize filenames
ref: MANAGER-15996

Signed-off-by: Paul Dickerson <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>
tibs245 pushed a commit that referenced this pull request Dec 13, 2024
@tibs245
refactor(*): veeam and vcd refactor post ga
2cd7050 
ref: MANAGER-15700

feat(vcd): add vcd reset password

ref: MANAGER-15191

Signed-off-by: Paul Dickerson <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>

feat(*): move vcd api to module

ref: MANAGER-15700

Signed-off-by: Nicolas Pierre-charles <[email protected]>
Signed-off-by: Paul Dickerson <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>

test(*): upgrade test dependencies

ref: MANAGER-15995

Signed-off-by: Nicolas Pierre-charles <[email protected]>

feat(hpc-vmware-managed-vcd): cleanup tests with test-utils

ref: MANAGER-15997

Signed-off-by: Nicolas Pierre-charles <[email protected]>

feat(vcd): implement usage tile in vdc dashboard

ref: MANAGER-15243

Signed-off-by: Paul Dickerson <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>

fix(*): fix packages versions

ref: MANAGER-00000

Signed-off-by: Nicolas Pierre-charles <[email protected]>

fix(*): improve test-utils

ref: MANAGER-00000

Signed-off-by: Nicolas Pierre-charles <[email protected]>

fix(vcd-veeam): fix failing test in delete-veeam

Signed-off-by: Paul Dickerson <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>

feat(vcd): rework translations structure and constant labels (#14318)

* feat(vcd): rework translations structure and constant labels

desc: update file structure and standardize filenames
ref: MANAGER-15996

Signed-off-by: Paul Dickerson <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>

fix(i18n): add missing translations [CDS 3556]

Signed-off-by: CDS Translator Agent <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>

feat(kms): refacto delete modal

ref: MANAGER-15233

Signed-off-by: Nicolas Pierre-charles <[email protected]>

fix(hycu): fix translation on edit name

ref: MANAGER-15973

Signed-off-by: Thibault Barske <[email protected]>

Signed-off-by: Thibault Barske <[email protected]>

fix(i18n): add missing translations [CDS 3559]

Signed-off-by: CDS Translator Agent <[email protected]>
tibs245 pushed a commit that referenced this pull request Dec 16, 2024
@pauldkn @tibs245
feat(vcd): rework translations structure and constant labels (#14318)
74e2eb0 
* feat(vcd): rework translations structure and constant labels

desc: update file structure and standardize filenames
ref: MANAGER-15996

Signed-off-by: Paul Dickerson <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>

fix(i18n): add missing translations [CDS 3556]

Signed-off-by: CDS Translator Agent <[email protected]>
Signed-off-by: Nicolas Pierre-charles <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipp972 chipp972 chipp972 approved these changes

@darsene darsene darsene approved these changes

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy was automatically assigned from ovh/team-manager-dev-angularjs

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pauldkn @chipp972 @darsene