Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pci-*): getMacroRegion #14398

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

refactor(pci-*): getMacroRegion #14398

wants to merge 1 commit into from

Conversation

frenautvh
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no
Tickets DTCORE-2912
License BSD 3-Clause

Description

refactor getMacroRegion

@frenautvh
refactor(pci-*): getMacroRegion
964a031 
ref: DTCORE-2912
Signed-off-by: Florian Renaut <[email protected]>
@frenautvh frenautvh requested review from a team as code owners December 3, 2024 13:33
@github-actions github-actions bot added universe-public-cloud refactor A code change that neither fixes a bug nor adds a feature labels Dec 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fredericvilcot
fredericvilcot approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@fredericvilcot fredericvilcot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seven-amid seven-amid seven-amid approved these changes

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@kqesar kqesar kqesar approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@selm3n selm3n Awaiting requested review from selm3n

@lionel95200x lionel95200x Awaiting requested review from lionel95200x

@ppprevost ppprevost Awaiting requested review from ppprevost

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
refactor A code change that neither fixes a bug nor adds a feature universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frenautvh @kqesar @fredericvilcot @seven-amid