Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager-react-components): storybook documentation auto generate #14403

Merged
merged 3 commits into from
Dec 9, 2024
Merged

fix(manager-react-components): storybook documentation auto generate #14403

merged 3 commits into from
Dec 9, 2024

Conversation

aboungnaseng-ovhcloud
Copy link
Contributor

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud commented Dec 3, 2024 •
edited
Loading

ref: MANAGER-15088

Question Answer
Branch? master
Bug fix? no
New feature? no
Breaking change? no
Tickets MANAGER-15698
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

  • Update storybook
  • Documentation and technical story
  • Add addons

Related

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud requested review from a team as code owners December 3, 2024 14:32
@github-actions github-actions bot added the feature New feature label Dec 3, 2024
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud force-pushed the feat/MANAGER-15698 branch 3 times, most recently from 202f16a to f45ebb4 Compare December 4, 2024 10:35
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Dec 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@etchteam/storybook-addon-status ADDED - 5.0.0

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud force-pushed the feat/MANAGER-15698 branch 9 times, most recently from f048411 to 6b2efb9 Compare December 9, 2024 09:09
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud changed the base branch from master to develop December 9, 2024 09:55
chipp972
chipp972 previously approved these changes Dec 9, 2024
View reviewed changes
@aboungnaseng-ovhcloud
feat(manager-react-components): update stories
bd4a522 
ref: MANAGER-15698

Signed-off-by: Alex Boungnaseng <[email protected]>
tristanwagner
tristanwagner approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@tristanwagner tristanwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud merged commit b50e47b into develop Dec 9, 2024
16 checks passed
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud deleted the feat/MANAGER-15698 branch December 9, 2024 12:52
qpavy pushed a commit that referenced this pull request Dec 10, 2024
@aboungnaseng-ovhcloud
fix(manager-react-components): storybook documentation auto generate (#…
04514b3 
…14403)

* fix(manager-react-components): storybook documentation auto generate
* feat(manager-react-components): delete deprecated dashboard components
* feat(manager-react-components): update stories

ref: MANAGER-15698

Signed-off-by: Alex Boungnaseng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanwagner tristanwagner tristanwagner approved these changes

@chipp972 chipp972 chipp972 approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aboungnaseng-ovhcloud @chipp972 @tristanwagner