Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-block-storage): add availability zone step for 3AZ region #14406

Merged
merged 3 commits into from
Jan 29, 2025
Merged

feat(pci-block-storage): add availability zone step for 3AZ region #14406

merged 3 commits into from
Jan 29, 2025

Conversation

SimonChaumet
Copy link
Contributor

@SimonChaumet SimonChaumet commented Dec 3, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-2111
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

  • implements new 1AZ chips
  • implements new 3AZ regions with availability zones
  • implements new volume catalog route for better performances

Related

@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch from 6817ef1 to c7dbadd Compare December 10, 2024 09:38
@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch from c7dbadd to 52cdc63 Compare December 20, 2024 10:44
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jan 7, 2025
@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch 4 times, most recently from 507aa7c to f6fc982 Compare January 9, 2025 17:07
@SimonChaumet SimonChaumet mentioned this pull request Jan 10, 2025
Merged
8 tasks
@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch from 90906a5 to 379fbf1 Compare January 13, 2025 08:00
@github-actions github-actions bot added dependencies Pull requests that update a dependency file and removed has conflicts Has conflicts to resolve before merging labels Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@ovh-ux/manager-pci-common UPDATED 0.14.4 0.15.0

@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch 2 times, most recently from 209036b to f9b1b8e Compare January 16, 2025 14:15
@SimonChaumet SimonChaumet marked this pull request as ready for review January 16, 2025 15:36
@SimonChaumet SimonChaumet requested review from a team as code owners January 16, 2025 15:36
fredericvilcot
fredericvilcot previously approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@fredericvilcot fredericvilcot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I wrote down some minor remarks, it's up to you 😌

packages/manager/apps/pci-block-storage/src/api/data/catalog.ts Outdated Show resolved Hide resolved
packages/manager/apps/pci-block-storage/src/api/data/catalog.ts Outdated Show resolved Hide resolved
packages/manager/apps/pci-block-storage/src/pages/new/components/AvailabilityZoneStep.tsx Outdated Show resolved Hide resolved
packages/manager/apps/pci-block-storage/src/pages/new/components/AvailabilityZoneStep.tsx Show resolved Hide resolved
packages/manager/apps/pci-block-storage/src/pages/new/components/LocationStep.component.tsx Show resolved Hide resolved
packages/manager/apps/pci-block-storage/src/pages/new/form.type.ts Show resolved Hide resolved
@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch from f9b1b8e to 08f6569 Compare January 16, 2025 16:33
@SimonChaumet SimonChaumet changed the title feat(pci-block-storage): add availability zone step feat(pci-block-storage): add availability zone step for 3AZ region Jan 17, 2025
@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch from 08f6569 to 348b94f Compare January 17, 2025 11:23
@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch from 8a7f003 to a8297bf Compare January 22, 2025 11:29
@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch from a8297bf to f36716f Compare January 22, 2025 11:56
@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch from f36716f to 50c486c Compare January 22, 2025 12:40
@fredericvilcot fredericvilcot changed the base branch from develop to release/pci-3AZ January 29, 2025 14:37
@fredericvilcot fredericvilcot self-assigned this Jan 29, 2025
@SimonChaumet SimonChaumet force-pushed the feat/block-storage-3AZ branch from 50c486c to 0c32f34 Compare January 29, 2025 15:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fredericvilcot fredericvilcot changed the base branch from release/pci-3AZ to release/public-cloud-3AZ January 29, 2025 15:39
anooparveti
anooparveti approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@anooparveti anooparveti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proxy approval instead of @JacquesLarique as it was previously approved by Jacques.

@fredericvilcot fredericvilcot merged commit 9f4f578 into release/public-cloud-3AZ Jan 29, 2025
11 of 13 checks passed
@fredericvilcot fredericvilcot deleted the feat/block-storage-3AZ branch January 29, 2025 16:44
@fredericvilcot fredericvilcot mentioned this pull request Jan 29, 2025
Merged
15 tasks
fredericvilcot pushed a commit that referenced this pull request Jan 30, 2025
@SimonChaumet @ovh-cds @fredericvilcot
feat(pci-block-storage): add availability zone step for 3AZ region (#…
0d749f9 
…14406)

ref: TAPC-1703

Signed-off-by: Simon Chaumet <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
fredericvilcot pushed a commit that referenced this pull request Jan 31, 2025
@SimonChaumet @ovh-cds @fredericvilcot
feat(pci-block-storage): add availability zone step for 3AZ region (#…
ff88262 
…14406)

ref: TAPC-1703

Signed-off-by: Simon Chaumet <[email protected]>
Co-authored-by: CDS Translator Agent <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@selm3n selm3n selm3n approved these changes

@anooparveti anooparveti anooparveti approved these changes

@Tsiorifamonjena Tsiorifamonjena Tsiorifamonjena approved these changes

@aottr aottr Awaiting requested review from aottr aottr was automatically assigned from ovh/team-manager-dev-reactjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-reactjs

@kqesar kqesar Awaiting requested review from kqesar kqesar was automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid was automatically assigned from ovh/su-digital-tools-core-stack

@darsene darsene Awaiting requested review from darsene darsene was automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique

Assignees

@fredericvilcot fredericvilcot

Labels
dependencies Pull requests that update a dependency file feature New feature quality check: ok translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SimonChaumet @Tsiorifamonjena @anooparveti @selm3n @fredericvilcot @JacquesLarique