Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-databases-analytics) - refactor data table and add filtering #14524

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(pci-databases-analytics) - refactor data table and add filtering #14524

wants to merge 2 commits into from

Conversation

jperchoc
Copy link
Contributor

@jperchoc jperchoc commented Dec 10, 2024 •
edited
Loading

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #DATATR-1763
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

Base automatically changed from feat/pci-db-analytics-rework-modals to release/public-cloud-w51 December 12, 2024 16:40
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 12, 2024
@fredericvilcot fredericvilcot force-pushed the release/public-cloud-w51 branch 2 times, most recently from 6b29873 to afc8dfc Compare December 12, 2024 17:02
@jperchoc jperchoc force-pushed the feat/data-table-sort-filter branch 2 times, most recently from 9a88aaf to de328be Compare December 13, 2024 16:02
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 13, 2024
@jperchoc jperchoc changed the title Feat/data table sort filter feat(pci-databases-analytics) - refactor data table and add filtering Dec 16, 2024
@fredericvilcot fredericvilcot force-pushed the release/public-cloud-w51 branch from 54e17af to 9da7f4f Compare December 16, 2024 13:21
@github-actions github-actions bot added has conflicts Has conflicts to resolve before merging universe-public-cloud labels Dec 16, 2024
@fredericvilcot fredericvilcot force-pushed the release/public-cloud-w51 branch 3 times, most recently from 58793cd to 0279f9d Compare December 16, 2024 13:58
Base automatically changed from release/public-cloud-w51 to master December 16, 2024 14:01
@jperchoc jperchoc force-pushed the feat/data-table-sort-filter branch from 878f3d5 to 4c1e100 Compare December 16, 2024 14:07
@github-actions github-actions bot added translation required and removed universe-public-cloud has conflicts Has conflicts to resolve before merging labels Dec 16, 2024
@jperchoc jperchoc marked this pull request as ready for review December 16, 2024 14:11
@jperchoc jperchoc requested review from a team as code owners December 16, 2024 14:11
abullet33
abullet33 reviewed Dec 17, 2024
View reviewed changes
packages/manager/apps/pci-databases-analytics/src/components/data-table/DataTable.tsx Outdated Show resolved Hide resolved
packages/manager/apps/pci-databases-analytics/src/components/data-table/DataTable.tsx Outdated Show resolved Hide resolved
...alytics/src/pages/services/[serviceId]/backups/_components/BackupsTableColumns.component.tsx Show resolved Hide resolved
...src/pages/services/[serviceId]/integrations/_components/IntegrationListColumns.component.tsx Show resolved Hide resolved
...src/pages/services/[serviceId]/integrations/_components/IntegrationListColumns.component.tsx Show resolved Hide resolved
...s/src/pages/services/[serviceId]/namespaces/_components/NamespacesTableColumns.component.tsx Show resolved Hide resolved
...s-analytics/src/pages/services/[serviceId]/pools/_components/PoolsTableColumns.component.tsx Show resolved Hide resolved
.../src/pages/services/[serviceId]/queries/_components/CurrentQueriesTableColumns.component.tsx Show resolved Hide resolved
...apps/pci-databases-analytics/src/pages/services/_components/ServiceListColumns.component.tsx Show resolved Hide resolved
...apps/pci-databases-analytics/src/pages/services/_components/ServiceListFilters.component.tsx Outdated Show resolved Hide resolved
@jperchoc
feat: rework datatables
431b997 
DATATR-1763

Signed-off-by: Jonathan Perchoc <[email protected]>
@jperchoc jperchoc force-pushed the feat/data-table-sort-filter branch from 4c1e100 to ccfdef7 Compare December 26, 2024 13:20
@jperchoc jperchoc requested a review from abullet33 December 26, 2024 13:21
@jperchoc
fix: pr comments
e3dff38 
Signed-off-by: Jonathan Perchoc <[email protected]>
@jperchoc jperchoc force-pushed the feat/data-table-sort-filter branch from ccfdef7 to e3dff38 Compare December 26, 2024 13:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abullet33 abullet33 abullet33 approved these changes

@kqesar kqesar Awaiting requested review from kqesar kqesar is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
feature New feature translation required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jperchoc @abullet33