Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-common): update region-selector components #14581

Merged
merged 3 commits into from
Dec 16, 2024
Merged

feat(pci-common): update region-selector components #14581

merged 3 commits into from
Dec 16, 2024

Conversation

fredericvilcot
Copy link
Contributor

@fredericvilcot fredericvilcot commented Dec 13, 2024 •
edited
Loading

ref: TAPC-2378

Question Answer
Branch? feat/TAPC-2378-bump-pci-common-ods-18
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-2378
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@github-actions github-actions bot added the feature New feature label Dec 13, 2024
@fredericvilcot fredericvilcot self-assigned this Dec 13, 2024
@fredericvilcot fredericvilcot force-pushed the feat/bump-region-selector-folder branch 2 times, most recently from 70fc14b to c0c1ade Compare December 13, 2024 16:49
@fredericvilcot fredericvilcot marked this pull request as ready for review December 13, 2024 16:50
@fredericvilcot fredericvilcot force-pushed the feat/TAPC-2378-bump-pci-common-ods-18 branch from 2d45e42 to 0019167 Compare December 13, 2024 19:58
@fredericvilcot fredericvilcot requested review from a team as code owners December 13, 2024 19:58
@fredericvilcot fredericvilcot requested review from oalkabouss, ghyenne and sachinrameshn and removed request for a team December 13, 2024 19:58
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 13, 2024
@fredericvilcot
build(pci-common): update dependencies & scripts
914eead 
ref: TAPC-2378
Signed-off-by: Frédéric Vilcot <[email protected]>
@fredericvilcot
feat(pci-common): update region-selector components
0408b8e 
ref: TAPC-2378
Signed-off-by: Frédéric Vilcot <[email protected]>
@fredericvilcot fredericvilcot force-pushed the feat/bump-region-selector-folder branch from c0c1ade to 36e3201 Compare December 16, 2024 09:02
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 16, 2024
@fredericvilcot fredericvilcot force-pushed the feat/bump-region-selector-folder branch 2 times, most recently from b8fdd56 to d8fb9b5 Compare December 16, 2024 09:10
@fredericvilcot fredericvilcot force-pushed the feat/bump-region-selector-folder branch from d8fb9b5 to 8853311 Compare December 16, 2024 09:53
@fredericvilcot
test(pci-common): update region-selector test suites
08fd2b7 
ref: TAPC-2378
Signed-off-by: Frédéric Vilcot <[email protected]>
@fredericvilcot fredericvilcot force-pushed the feat/bump-region-selector-folder branch from 8853311 to 08fd2b7 Compare December 16, 2024 09:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@fredericvilcot fredericvilcot merged commit b1ccd3c into feat/TAPC-2378-bump-pci-common-ods-18 Dec 16, 2024
12 of 14 checks passed
@fredericvilcot fredericvilcot deleted the feat/bump-region-selector-folder branch December 16, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenautvh frenautvh frenautvh approved these changes

@lionel95200x lionel95200x lionel95200x approved these changes

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne was automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn was automatically assigned from ovh/team-manager-dev-angularjs

Assignees

@fredericvilcot fredericvilcot

Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredericvilcot @lionel95200x @frenautvh