Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dedicated): add get mac list for POP L2 #14738

Open
wants to merge 2 commits into
base: feat/MANAGER-15807
Choose a base branch
from
Open

feat(dedicated): add get mac list for POP L2 #14738

wants to merge 2 commits into from
+42 −5

Conversation

mhelhali-soufien
Copy link
Contributor

Question Answer
Branch? feat/occ-diagnostic)
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-15808
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

feat(dedicated): add get mac list for POP L2
d639374 
  ref: MANAGER-15808

Signed-off-by: soufien mhelhali <[email protected]>
@mhelhali-soufien mhelhali-soufien requested a review from a team as a code owner December 30, 2024 09:14
@mhelhali-soufien mhelhali-soufien requested review from qpavy, anooparveti and JacquesLarique and removed request for a team December 30, 2024 09:14
qpavy
qpavy reviewed Dec 31, 2024
View reviewed changes
packages/manager/modules/cloud-connect/src/details/overview/translations/Messages_fr_FR.json Outdated
@@ -40,6 +40,7 @@
"cloud_connect_pop_diagnostic": "POP Diagnostic",
"cloud_connect_pop_diagnostic_link": "Voir les résultats de mes diagnostiques",
"cloud_connect_pop_diagnostic_check": "Test BGP Peering",
"cloud_connect_pop_get_mac_list": "Get Mac List",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"cloud_connect_pop_get_mac_list": "Get Mac List",
"cloud_connect_pop_get_mac_list": "Voir la liste de mes adresses MAC",

feat(dedicated): fix button text
fdcae6a 
  ref: MANAGER-15808

Signed-off-by: soufien mhelhali <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@qpavy qpavy qpavy approved these changes

@anooparveti anooparveti Awaiting requested review from anooparveti anooparveti is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhelhali-soufien @qpavy @sachinrameshn