feat(pci-common): add pci saving plan banner #14739
Open
+151
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredericvilcot
requested changes
Dec 30, 2024
.../modules/manager-pci-common/src/components/banner/saving-plan-banner/PciSavingPlanBanner.tsx
Outdated
Show resolved
Hide resolved
.../modules/manager-pci-common/src/components/banner/saving-plan-banner/PciSavingPlanBanner.tsx
Outdated
Show resolved
Hide resolved
lionel95200x
previously approved these changes
Dec 30, 2024
Signed-off-by: Frédéric Vilcot <[email protected]>
ppprevost
changed the base branch from
maintenance/manager-pci-common-v0.x
to
ci/filter-tests-and-build
added 9 commits
December 31, 2024 10:24
Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: Pierre-Philippe <[email protected]>
Signed-off-by: Pierre-Philippe <[email protected]>
ppprevost
force-pushed
the
feat/add-pci-saving-plan
branch
from
8f1f810 to
24fa9dd
Compare
|
ppprevost
changed the base branch from
ci/filter-tests-and-build
to
maintenance/manager-pci-common-v0.x
ppprevost
dismissed
lionel95200x’s stale review
The base branch was changed.
SimonChaumet
approved these changes
Jan 6, 2025
| const navigateToSavingsPlan = async () => { | ||
| await navigateTo( | ||
| 'public-cloud', | ||
| `#/pci/projects/${projectURL}/savings-plan`, |
There was a problem hiding this comment.
shouldn't this come from shell context ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related