fix(svp): design issue after bump ods18 #14741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel95200x
requested review from
sidlynx,
seven-amid,
MaximeBajeux,
anooparveti and
JacquesLarique
and removed request for
a team
lionel95200x
force-pushed
the
fix/TAPC-2456-svp-design-18
branch
from
cb673a8 to
520c9f8
Compare
github-actions
bot
added
the
has conflicts
lionel95200x
force-pushed
the
fix/TAPC-2456-svp-design-18
branch
from
520c9f8 to
56f57e1
Compare
github-actions
bot
removed
the
has conflicts
lionel95200x
force-pushed
the
fix/TAPC-2456-svp-design-18
branch
from
56f57e1 to
da6d63e
Compare
ppprevost
requested changes
Jan 2, 2025
packages/manager/apps/pci-savings-plan/src/components/Commitment/Commitment.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/pci-savings-plan/src/components/Modal/RenewModal.tsx
Outdated
Show resolved
Hide resolved
ref: TAPC-2456 Signed-off-by: Lionel Bueno <[email protected]>
lionel95200x
force-pushed
the
fix/TAPC-2456-svp-design-18
branch
from
da6d63e to
8ffebf7
Compare
|
Eric-ciccotti
approved these changes
Jan 3, 2025
| @@ -4,13 +4,17 @@ import React from 'react'; | |||
| const SimpleTile: React.FC<React.PropsWithChildren<{ | |||
| onClick?: () => void; | |||
| isActive?: boolean; | |||
| }>> = ({ children, onClick, isActive }) => ( | |||
| className?: string; | |||
| }>> = ({ children, onClick, isActive, className }) => ( | |||
| <OdsCard | |||
| className={`flex items-center flex-col justify-center w-1/2 shrink-0 md:shrink md:w-1/4 mr-5 text-center p-3 ${ | |||
There was a problem hiding this comment.
a little bit hard to read
There was a problem hiding this comment.
a great idea is to use clsx
ppprevost
approved these changes
Jan 3, 2025
lionel95200x
added a commit
that referenced
this pull request
Jan 6, 2025
ref: TAPC-2456 Signed-off-by: Lionel Bueno <[email protected]> Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x
added a commit
that referenced
this pull request
Jan 7, 2025
ref: TAPC-2456 Signed-off-by: Lionel Bueno <[email protected]> Co-authored-by: Lionel Bueno <[email protected]>
lionel95200x
added a commit
that referenced
this pull request
Jan 7, 2025
ref: TAPC-2456 Signed-off-by: Lionel Bueno <[email protected]>
lionel95200x
added a commit
that referenced
this pull request
Jan 8, 2025
ref: TAPC-2456 Signed-off-by: Lionel Bueno <[email protected]>
lionel95200x
added a commit
that referenced
this pull request
Jan 15, 2025
ref: TAPC-2456 Signed-off-by: Lionel Bueno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tapc-2456Description
Update some design on ODS 18
Related