Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dedicated.server): rbx1 eol banner #14742

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

qpavy
Copy link
Contributor

@qpavy qpavy commented Dec 31, 2024

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #MANAGER-16530
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • [ ] Breaking change is mentioned in relevant commits

Description

Related

  • CMT-20396

chipp972
chipp972 previously approved these changes Dec 31, 2024
ref: MANAGER-16530

Signed-off-by: Quentin Pavy <[email protected]>
@qpavy qpavy dismissed stale reviews from chipp972 and mhelhali-soufien via 40fdfcc December 31, 2024 11:15
@qpavy qpavy force-pushed the feat/MANAGER-16530 branch from 3b60540 to 40fdfcc Compare December 31, 2024 11:15
chipp972
chipp972 previously approved these changes Dec 31, 2024
sachinrameshn
sachinrameshn previously approved these changes Jan 13, 2025
chipp972
chipp972 previously approved these changes Jan 13, 2025
@chipp972 chipp972 changed the base branch from develop to release/infra-hpc-w3 January 13, 2025 15:39
@chipp972 chipp972 changed the base branch from release/infra-hpc-w3 to develop January 13, 2025 15:42
@chipp972 chipp972 dismissed stale reviews from sachinrameshn and themself January 13, 2025 15:42

The base branch was changed.

Copy link

@mhelhali-soufien mhelhali-soufien changed the base branch from develop to release/infra-hpc-w4 January 17, 2025 11:45
@mhelhali-soufien mhelhali-soufien merged commit f674d47 into release/infra-hpc-w4 Jan 17, 2025
16 of 17 checks passed
@mhelhali-soufien mhelhali-soufien deleted the feat/MANAGER-16530 branch January 17, 2025 11:46
@mhelhali-soufien mhelhali-soufien mentioned this pull request Jan 20, 2025
4 tasks
mhelhali-soufien pushed a commit that referenced this pull request Jan 20, 2025
* feat(dedicated.server): rbx1 eol banner

ref: MANAGER-16530

Signed-off-by: Quentin Pavy <[email protected]>

* fix(i18n): add missing translations [CDS 3616]

Signed-off-by: CDS Translator Agent <[email protected]>

* feat(dedicated.server): display rb1x banner for rbx1 not in ct rack

ref: MANAGER-16530

Signed-off-by: Quentin Pavy <[email protected]>

---------

Signed-off-by: Quentin Pavy <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
Co-authored-by: Quentin Pavy <[email protected]>
aottr pushed a commit that referenced this pull request Jan 21, 2025
* feat(dedicated.server): rbx1 eol banner

ref: MANAGER-16530

Signed-off-by: Quentin Pavy <[email protected]>

* fix(i18n): add missing translations [CDS 3616]

Signed-off-by: CDS Translator Agent <[email protected]>

* feat(dedicated.server): display rb1x banner for rbx1 not in ct rack

ref: MANAGER-16530

Signed-off-by: Quentin Pavy <[email protected]>

---------

Signed-off-by: Quentin Pavy <[email protected]>
Signed-off-by: CDS Translator Agent <[email protected]>
Co-authored-by: Quentin Pavy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants