Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mrc): allow action banner to be dismissible #14755

Merged
merged 1 commit into from
Jan 6, 2025
Merged

feat(mrc): allow action banner to be dismissible #14755

merged 1 commit into from
Jan 6, 2025

Conversation

lionel95200x
Copy link
Contributor

@lionel95200x lionel95200x commented Jan 2, 2025 •
edited
Loading

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets #14754
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Add isDismissible on ActionBanner

Related

@lionel95200x lionel95200x requested review from a team as code owners January 2, 2025 13:58
@github-actions github-actions bot added the feature New feature label Jan 2, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@anooparveti anooparveti linked an issue Jan 3, 2025 that may be closed by this pull request
[manager-components]: Allow Action Banner dismissible #14754
Closed
1 task
@anooparveti anooparveti merged commit f273e8e into master Jan 6, 2025
19 checks passed
@anooparveti anooparveti deleted the feat/mrc-action-banner-dismissible branch January 6, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachinrameshn sachinrameshn sachinrameshn approved these changes

@anooparveti anooparveti anooparveti approved these changes

@ppprevost ppprevost ppprevost approved these changes

@SimonChaumet SimonChaumet SimonChaumet approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[manager-components]: Allow Action Banner dismissible
5 participants
@lionel95200x @SimonChaumet @ppprevost @anooparveti @sachinrameshn