Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(telecom): add the outbound proxy on sip account informations #14759

Merged
merged 1 commit into from
Jan 6, 2025
Merged

feat(telecom): add the outbound proxy on sip account informations #14759

merged 1 commit into from
Jan 6, 2025

Conversation

Mouddane
Copy link

@Mouddane Mouddane commented Jan 2, 2025

Question Answer
Branch? master
Bug fix? no
New feature? yes
Breaking change? no
Tickets -
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

A field has been added on the api for a few weeks to display the outbound proxy used by the sip account, this change adds it to the manager

@Mouddane Mouddane requested a review from a team as a code owner January 2, 2025 17:19
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ghyenne ghyenne changed the base branch from master to fix/MANAGER-16637 January 6, 2025 11:05
@ghyenne ghyenne merged commit c3740d2 into ovh:fix/MANAGER-16637 Jan 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stif59100 stif59100 stif59100 approved these changes

@ghyenne ghyenne ghyenne approved these changes

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 was automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss was automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique was automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
feature New feature translation required universe-telecom
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mouddane @ghyenne @stif59100