Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mrc): region-selector component #14770

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

chipp972
Copy link
Contributor

@chipp972 chipp972 commented Jan 3, 2025

ref: MANAGER-16479

Question Answer
Branch? develop
Bug fix? no
New feature? yes
Breaking change? no
Tickets MANAGER-16479
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@chipp972 chipp972 requested review from a team as code owners January 3, 2025 16:29
@github-actions github-actions bot added translation required dependencies Pull requests that update a dependency file feature New feature labels Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
flag-icons ADDED - 7.2.3

ref: MANAGER-16479

Signed-off-by: Nicolas Pierre-charles <[email protected]>
@chipp972 chipp972 force-pushed the feat/region-selector-component branch from 950f58b to 0e7d5ad Compare January 6, 2025 13:30
Copy link

sonarqubecloud bot commented Jan 6, 2025

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it miss some regions. Check on this filehttps://github.com/ovh/manager/blob/master/packages/manager/modules/manager-components/src/region/translations/Messages_fr_FR.json

@chipp972 chipp972 linked an issue Jan 6, 2025 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature New feature translation required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[manager-components]: Region select component
2 participants