feat(nutanix): add install node popin #14771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibs245
requested review from
qpavy,
oalkabouss and
darsene
and removed request for
a team
github-actions
bot
added
translation required
universe-hosted-private-cloud
feature
tibs245
force-pushed
the
feat/MANAGER-15712-nutanix-install-node
branch
from
9b69f45 to
94faa2d
Compare
anooparveti
reviewed
Jan 6, 2025
packages/manager/modules/nutanix/src/dashboard/component/install-node-modal/controller.js
Outdated
Show resolved
Hide resolved
anooparveti
reviewed
Jan 6, 2025
packages/manager/modules/nutanix/src/dashboard/component/install-node-modal/module.js
Outdated
Show resolved
Hide resolved
anooparveti
requested changes
Jan 6, 2025
There was a problem hiding this comment.
The implementation seems much similar to what has been done for Install & Reinstall (#14772). Try and create reusable components and reuse it for both the cases.
8 tasks
anooparveti
reviewed
Jan 6, 2025
packages/manager/modules/nutanix/src/dashboard/component/install-node-modal/template.html
Outdated
Show resolved
Hide resolved
anooparveti
reviewed
Jan 6, 2025
packages/manager/modules/nutanix/src/dashboard/component/install-node-modal/template.html
Outdated
Show resolved
Hide resolved
anooparveti
reviewed
Jan 6, 2025
anooparveti
requested changes
Jan 6, 2025
ref: MANAGER-15712 Signed-off-by: Thibault Barske <[email protected]>
tibs245
force-pushed
the
feat/MANAGER-15712-nutanix-install-node
branch
from
94faa2d to
7fdfab9
Compare
anooparveti
requested changes
Jan 7, 2025
packages/manager/modules/nutanix/src/dashboard/component/install-node-modal/module.js
Outdated
Show resolved
Hide resolved
| type="text" | ||
| name="ahvIp" | ||
| data-ng-model-options="{ debounce: 500 }" | ||
| data-ng-pattern="$ctrl.IPV4_REGEX" |
There was a problem hiding this comment.
nitpick: Use ipaddr.js to validate the IPv4 address.
There was a problem hiding this comment.
Done, I create a directive "ipValidator" and refactor the "redeploy cluster" component with this
ThibaudCrespin
approved these changes
Jan 8, 2025
Signed-off-by: Thibault Barske <[email protected]>
|
anooparveti
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat/nutanix-scale-in-out