Skip to content

feat(manager-react-components): add strict mode in new components #17739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: project/mrc-v3
Choose a base branch
from

Conversation

aboungnaseng-ovhcloud
Copy link
Contributor

Description

  • Adding typescript strict mode for new components in tsconfig.new.json

Ticket Reference: #MANAGER-15000

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud requested a review from a team as a code owner June 20, 2025 08:02
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud requested review from helabenkhalfallah and anooparveti and removed request for a team June 20, 2025 08:02
@github-actions github-actions bot added dependencies Pull requests that update a dependency file feature New feature labels Jun 20, 2025
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud changed the title Feat/manager 15000 feat(manager-react-components): add strict mode in new components Jun 20, 2025
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jun 20, 2025
},
"files": ["global.d.ts"],
"include": [
// Add you components migrated here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not migrate directly to strict mode ? It will be very hard to maintain with this two tsconfig file
Maybe you could enable strict mode and override some error in warning ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its only temporary, we will keep only one tsconfig file, once we we will correct all the error and the warning in strict mode

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aboungnaseng-ovhcloud
Why not :

  • adding strict mode by default in tsconfig.json
  • adding a tsconfig.build.json that overrides the strict mode to false to allow the lib to be built?

Something like:

// to remove after package has been cleaned up
{
  "extends": "./tsconfig",
  "compilerOptions": {
    "strict": false 
  }
}

@aboungnaseng-ovhcloud aboungnaseng-ovhcloud changed the base branch from build/add-ods-react to project/mrc-v3 June 20, 2025 13:43
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Jun 20, 2025
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud force-pushed the feat/MANAGER-15000 branch 2 times, most recently from 84fe38b to 181cba4 Compare June 20, 2025 13:57
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud requested review from a team as code owners June 20, 2025 13:57
@aboungnaseng-ovhcloud aboungnaseng-ovhcloud requested review from tibs245, darsene and vovh and removed request for a team June 20, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants