-
Notifications
You must be signed in to change notification settings - Fork 103
feat(manager-react-components): add strict mode in new components #17739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: project/mrc-v3
Are you sure you want to change the base?
Conversation
1c6a9a3
to
08526b6
Compare
}, | ||
"files": ["global.d.ts"], | ||
"include": [ | ||
// Add you components migrated here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not migrate directly to strict mode ? It will be very hard to maintain with this two tsconfig
file
Maybe you could enable strict mode and override some error in warning ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its only temporary, we will keep only one tsconfig file, once we we will correct all the error and the warning in strict mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aboungnaseng-ovhcloud
Why not :
- adding strict mode by default in
tsconfig.json
- adding a
tsconfig.build.json
that overrides the strict mode to false to allow the lib to be built?
Something like:
// to remove after package has been cleaned up
{
"extends": "./tsconfig",
"compilerOptions": {
"strict": false
}
}
08526b6
to
3ecb6bc
Compare
84fe38b
to
181cba4
Compare
181cba4
to
7b3ea35
Compare
ref: #MANAGER-15000 Signed-off-by: Alex Boungnaseng <[email protected]>
7b3ea35
to
95423fe
Compare
Description
Ticket Reference: #MANAGER-15000