Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add resource ovh_domain_name #837

Merged
merged 1 commit into from
Feb 24, 2025
Merged

feat: Add resource ovh_domain_name #837

merged 1 commit into from
Feb 24, 2025

Conversation

amstuta
Copy link
Contributor

@amstuta amstuta commented Feb 14, 2025 •
edited by bigbigbang
Loading

Description

Add resource ovh_domain_name.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Test A: make testacc TESTARGS="-run TestAccResourceDomainName_basic"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@amstuta amstuta requested a review from a team as a code owner February 14, 2025 14:34
@amstuta amstuta linked an issue Feb 18, 2025 that may be closed by this pull request
New resource: ovh_domain #146
Closed
mxpetit
mxpetit previously approved these changes Feb 18, 2025
View reviewed changes
rbeuque74
rbeuque74 requested changes Feb 18, 2025
View reviewed changes
ovh/resource_domain_name.go Outdated

serviceName := data.DomainName.ValueString()

serviceID, err := serviceIdFromResourceName(r.config.OVHClient, serviceName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/services service name are not unique, meaning that domain name will have the same service name than the web hosting attached to the domain name, or the dns zone

As here

terraform-provider-ovh/ovh/services.go

Line 57 in 257f28b

return serviceIds[0], nil
, we are returning the first service, we might not delete the right one.

We need to make serviceIdFromResourceName evolve to handle "serviceType"

website/docs/r/domain_name.html.markdown Outdated

```hcl
resource "ovh_domain_name" "domain" {
domain_name = "a-great-domain.ovh"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
domain_name = "a-great-domain.ovh"
domain_name = "example.com"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had previous case in Golang code base where they use funny domain name for their tests, and the domain was not registered. Then this domain started to display undesirable content.
Let's stick to example.com here, which is a protected domain for documentation and RFC

@amstuta amstuta force-pushed the dev/aamstutz/add-domain-name branch from 257f28b to 182f006 Compare February 21, 2025 14:02
rbeuque74
rbeuque74 requested changes Feb 24, 2025
View reviewed changes
ovh/services.go Outdated
@@ -57,6 +57,17 @@ func serviceIdFromResourceName(c *ovh.Client, resourceName string) (int, error)
return serviceIds[0], nil
}

func serviceIdFromRouteAndResourceName(c *ovh.Client, route, resourceName string) (int, error) {
var serviceIds []int
endpoint := fmt.Sprintf("/services?resourceName=%s&routes=%s", url.PathEscape(resourceName), url.PathEscape(route))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
endpoint := fmt.Sprintf("/services?resourceName=%s&routes=%s", url.PathEscape(resourceName), url.PathEscape(route))
endpoint := fmt.Sprintf("/services?resourceName=%s&routes=%s", url.QueryEscape(resourceName), url.QueryEscape(route))

@amstuta amstuta force-pushed the dev/aamstutz/add-domain-name branch from 182f006 to faff727 Compare February 24, 2025 10:50
@amstuta amstuta merged commit 76970d5 into master Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deathiop deathiop deathiop left review comments

@rbeuque74 rbeuque74 rbeuque74 approved these changes

@mxpetit mxpetit mxpetit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New resource: ovh_domain
4 participants
@amstuta @rbeuque74 @deathiop @mxpetit