feat: add vrack data source #854
Open
+109
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justas200
approved these changes
Feb 21, 2025
amstuta
requested changes
Feb 21, 2025
| err := config.OVHClient.Get( | ||
| fmt.Sprintf( | ||
| "/vrack/%s", | ||
| serviceName, |
There was a problem hiding this comment.
Suggested change
| serviceName, | |
| url.PathEscape(serviceName), |
| }) | ||
| } | ||
|
|
||
| const testAccVrackDatasourceConfig_Basic = ` |
There was a problem hiding this comment.
could you move this definition in the test func itself to avoid the global variable ?
| @@ -396,6 +396,11 @@ func testAccPreCheckOkmsCredential(t *testing.T) { | |||
| checkEnvOrSkip(t, "OVH_OKMS_CREDENTIAL") | |||
| } | |||
|
|
|||
| func testAccPreCheckVrack(t *testing.T) { | |||
There was a problem hiding this comment.
can be removed, there is already the testAccPreCheckVRack func that does the same thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding single vRack retrieval data source support
There is currently no raised issue that needs this functionality, however I have noticed it is missing and I need it for a project.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Simple unit test like implemented for VPS retrieval.
Checklist:
go mod vendorif I added or modifygo.modfile