-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement readthedocs #1599
base: main
Are you sure you want to change the base?
Implement readthedocs #1599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good start!
If we are going to have all of the rst files checked into the tree, then I think we need to remove the man files. We don't want to have to deal with keeping two different formats of the same documentation updated. On or the other should be auto-generated. I'd vote for switching to rst.
I'm not at all a fan of sprinkling index.rst files throughout the tree. I don't think the documentation and man pages would necessarily need to mimic the code tree structure, especially for man pages. I think we should have co-located high level files that contain the document structure, and has pointers to the various documents it links to.
If we move to .rst files and delete the .man files, then we need to make rst2man a requirement in configure.ac. We probably need to iterate a bit on tree structure.
@morrone Thanks for reviewing this! I've updated the branch with the suggested changes but haven’t modified the tree structure under docs/man/ yet. It seems that most of us are on board with transitioning to .rst, and I agree that we should discuss the best way to organize these documents (maybe during the next LDMS UG meeting) before removing any existing .man files. @tom95858, do you have any other thoughts or suggestions? |
I have no strong feelings about summary and umbrella documentation locations, but the .rst file(s) specific to a plugin should live in the directory with the plugin. This allows the contributor of a plugin to work in a clearly defined sandbox. |
I agree. I just want to get rid of the "index.rst" files that are strewn throughout, not the content rst files (which would be the man page source as well. |
We might also take this opportunity to put some consistency in place wrt man page naming and to drop/change the 'plugin' prefix on our plugin man pages. As complex tooling manuals go, the pattern for git man page naming is one of the least unpleasant I've run into in quite a while. We could, if people riot, keep the old aliases for plugin man pages. |
I completely agree! They should all have a better prefix like "ldmsd_", "ldmsd_plugin_", whatever. "Plugin_" is just too generic for installing globally on a system. |
I would like all the following to return something sensible (note the lack of a pedantic plugin type namespacing):
and I would eventually like
to return:
|
This PR includes all LDMS-related documentation and Read the Docs (RTD) configuration files, such as .rst files, conf.py, Makefile, and others. It also adds a GitHub Actions workflow, "Build and Trigger Read the Docs", which automates the generation and updating of documentation whenever changes are made to specific files in the docs/ directory.
A couple things to note:
GITHUB ACTIONS WORKFLOW:
push
orpull_request
events when changes occur in:docs/
directory orrst
files.generate-rst
pandoc
for file conversion..man
files to.rst
format, ifCONVERT_MAN_PAGES
is set totrue
.- Note: This is a temporary step during the transition from .man to .rst documentation. If developers continue to add .man files, they can easily be converted by enabling CONVERT_MAN_PAGES.
index.rst
files dynamically to reflect added/removed or modified.rst
files.build-docs
generate-rst
.