Remove stale LRSRs from default and network scopped cluster router #4679
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| package util | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "net" | ||
| "testing" | ||
|
|
||
| "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/config" | ||
| "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/nbdb" | ||
| libovsdbtest "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/testing/libovsdb" | ||
| "github.com/ovn-org/ovn-kubernetes/go-controller/pkg/types" | ||
| ) | ||
|
|
||
| func TestCreateDefaultRouteToExternal(t *testing.T) { | ||
| nodeName := "ovn-control-plane" | ||
| _, cidr4, _ := net.ParseCIDR("10.128.0.0/14") | ||
| config.Default.ClusterSubnets = []config.CIDRNetworkEntry{{cidr4, 24}} | ||
| expectedStaticRoute := &nbdb.LogicalRouterStaticRoute{ | ||
| Nexthop: "100.64.0.1", | ||
| IPPrefix: "10.128.0.0/14", | ||
| Policy: &nbdb.LogicalRouterStaticRoutePolicySrcIP, | ||
| UUID: "route1-UUID", | ||
| } | ||
| unexpectedStaticRoute := &nbdb.LogicalRouterStaticRoute{ | ||
| Nexthop: "100.66.0.1", | ||
| IPPrefix: "10.128.0.0/14", | ||
| Policy: &nbdb.LogicalRouterStaticRoutePolicySrcIP, | ||
| UUID: "route2-UUID", | ||
| } | ||
| initialOVNClusterRouter := &nbdb.LogicalRouter{ | ||
| UUID: types.OVNClusterRouter + "-UUID", | ||
| Name: types.OVNClusterRouter, | ||
| StaticRoutes: []string{"route2-UUID"}, | ||
| } | ||
| expectedOVNClusterRouter := &nbdb.LogicalRouter{ | ||
| UUID: types.OVNClusterRouter + "-UUID", | ||
| Name: types.OVNClusterRouter, | ||
| StaticRoutes: []string{"route1-UUID"}, | ||
| } | ||
| expectedLogicalRouterPort := &nbdb.LogicalRouterPort{ | ||
| Name: types.GWRouterToJoinSwitchPrefix + types.GWRouterPrefix + nodeName, | ||
| UUID: types.GWRouterToJoinSwitchPrefix + types.GWRouterPrefix + nodeName + "-UUID", | ||
| Networks: []string{"100.64.0.1/16"}, | ||
| } | ||
| GRName := "GR_" + nodeName | ||
| expectedOVNGatewayRouter := &nbdb.LogicalRouter{ | ||
| UUID: GRName + "-UUID", | ||
| Name: GRName, | ||
| Ports: []string{types.GWRouterToJoinSwitchPrefix + types.GWRouterPrefix + nodeName + "-UUID"}, | ||
| } | ||
|
|
||
| tests := []struct { | ||
| desc string | ||
| initialNbdb libovsdbtest.TestSetup | ||
| expectedNbdb libovsdbtest.TestSetup | ||
| }{ | ||
| { | ||
| desc: "removes stale static route and creates new route with current gateway router logical port IP", | ||
| initialNbdb: libovsdbtest.TestSetup{ | ||
| NBData: []libovsdbtest.TestData{ | ||
| unexpectedStaticRoute, | ||
| initialOVNClusterRouter, | ||
| expectedLogicalRouterPort, | ||
| expectedOVNGatewayRouter, | ||
| }, | ||
| }, | ||
| expectedNbdb: libovsdbtest.TestSetup{ | ||
| NBData: []libovsdbtest.TestData{ | ||
| expectedStaticRoute, | ||
| expectedOVNClusterRouter, | ||
| expectedLogicalRouterPort, | ||
| expectedOVNGatewayRouter, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| for i, tc := range tests { | ||
| t.Run(fmt.Sprintf("%d:%s", i, tc.desc), func(t *testing.T) { | ||
| nbClient, cleanup, err := libovsdbtest.NewNBTestHarness(tc.initialNbdb, nil) | ||
| if err != nil { | ||
| t.Fatal(fmt.Errorf("test: \"%s\" failed to create test harness: %v", tc.desc, err)) | ||
| } | ||
| t.Cleanup(cleanup.Cleanup) | ||
|
|
||
| var e error | ||
| if e = CreateDefaultRouteToExternal(nbClient, types.OVNClusterRouter, GRName); e != nil { | ||
| t.Fatal(fmt.Errorf("failed to create pod to external catch-all reroute for gateway router %s, err: %v", GRName, e)) | ||
| } | ||
| matcher := libovsdbtest.HaveDataIgnoringUUIDs(tc.expectedNbdb.NBData) | ||
| success, err := matcher.Match(nbClient) | ||
| if !success { | ||
| t.Fatal(fmt.Errorf("test: \"%s\" didn't match expected with actual, err: %v", tc.desc, matcher.FailureMessage(nbClient))) | ||
| } | ||
| if err != nil { | ||
| t.Fatal(fmt.Errorf("test: \"%s\" encountered error: %v", tc.desc, err)) | ||
| } | ||
| }) | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the test!!
Would you mind adding one for the first commit too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure