Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inactivity probe for ovsdb connection #356

Merged
merged 6 commits into from
Jul 11, 2023
Merged

Add inactivity probe for ovsdb connection #356

merged 6 commits into from
Jul 11, 2023

Commits on Jul 3, 2023

  1. Add inactivity probe for ovsdb connection 

    This enhances ovsdb client to sends echo request periodically at specified
interval to ovsdb server, when echo request fails consecutively 2 * interval
then consider connection as inactive and then attempts to reconnect with server.
This ensures early detection of ovsdb server connectivity issues and reconnect
to the server immediately when it's back to operational.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
    @pperiyasamy
    pperiyasamy committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    88bbe8c View commit details
    Browse the repository at this point in the history

  2. Add unit test for testing ovsdb inactivity 

    This commit adds necessary changes into server for tweaking echo handler
to throw error and add an unit test for aliveness of server connection.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
    @pperiyasamy
    pperiyasamy committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    9e373c1 View commit details
    Browse the repository at this point in the history

  3. Fix inactivity test for multiple echo off and on 

    This commit needed to fix issues in inactivity check handling
logic when the test is enhanced to have toggling echo reply
multiple times on the ovsdb server.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
    @pperiyasamy
    pperiyasamy committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    f85c008 View commit details
    Browse the repository at this point in the history

  4. Use consistent naming for inactivity 

    This commit changes to use a consistent naming in options and client
module for inactivity related variables and methods. It also fixes
a deadlock scenario between rpcMutex and inactivityCheckStopped ch
when shutdown and echo request happening at the same time.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
    @pperiyasamy
    pperiyasamy committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    494ad2f View commit details
    Browse the repository at this point in the history

  5. Reuse reconnect logic for inactivity check 

    This reuses reconnect code associated with handling disconnect notification
for the echo failure, It makes code more readble and avoids unneccessary use
of additional mutexes and flags.

It also avoids sending echo unnecessarily when ovsdb traffic going on with
server connection and that's being for connection aliveness check which
saves some cpu cycles and echo traffic on the wire.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
    @pperiyasamy
    pperiyasamy committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    b833418 View commit details
    Browse the repository at this point in the history

  6. Fix table test 

    This fixes field type test on a ovsdb table.

Signed-off-by: Periyasamy Palanisamy <[email protected]>
    @pperiyasamy
    pperiyasamy committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    685d3ee View commit details
    Browse the repository at this point in the history