client.go: allow transaction logs to use a specific logger #361
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @jcaamano |
flavio-fernandes
force-pushed
the
libovsdb-txn-log
branch
from
2026483
to
d9865d0
Compare
Provide an option to logger to explictly direct transactions logs. When not specified, client.logger remains as the used logger. Reported-at: https://issues.redhat.com/browse/SDN-3507 Signed-off-by: Flavio Fernandes <[email protected]>
flavio-fernandes
force-pushed
the
libovsdb-txn-log
branch
from
d9865d0
to
36b11f9
Compare
|
/hold |
halfcrazy
reviewed
Aug 15, 2023
| if dbgLogger.Enabled() { | ||
| dbgLogger.Info("transacting operations", "operations", fmt.Sprintf("%+v", operation)) | ||
| // Use dedicated logger for providing transactions. | ||
| if o.txnLogger.Enabled() { |
There was a problem hiding this comment.
How about injecting the logger from context? If so we can share a client and let different Transact calls use different log contexts.
something like log.FrromContext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an option to logger to explictly direct transactions logs. When not specified, client.logger remains as the used logger.
Reported-at: https://issues.redhat.com/browse/SDN-3507