Skip to content

Commit

Permalink
northd: Reset ls_datapath_group if not all chassis support it.
Browse files Browse the repository at this point in the history
The correct upgrade procedure mentions that databases are upgraded
at the same time as ovn-northd, so there's nothing that doesn't allow
northd to write to new columns.  The feature flag reports instead what
features chassis are aware of.  In this specific case, if a chassis
doesn't know how to interpret the 'ls_datapaths' column, ovn-northd
should set it to NULL and use the deprecated 'datapath' one.

Fixes: ab7a8fe ("northd: introduce ls_datapath_group column in lb sb db table")
Signed-off-by: Dumitru Ceara <[email protected]>
Acked-by: Ales Musil <[email protected]>
  • Loading branch information
dceara committed Oct 11, 2023
1 parent 0c22ac3 commit 5efdf01
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions northd/northd.c
Original file line number Diff line number Diff line change
Expand Up @@ -4678,6 +4678,7 @@ sync_lbs(struct ovsdb_idl_txn *ovnsb_txn,
sbrec_load_balancer_set_datapath_group(sbrec_lb, NULL);
} else {
/* datapath_group column is deprecated. */
sbrec_load_balancer_set_ls_datapath_group(sbrec_lb, NULL);
sbrec_load_balancer_set_datapath_group(
sbrec_lb, lb_dpg ? lb_dpg->dp_group : NULL
);
Expand Down

0 comments on commit 5efdf01

Please sign in to comment.