fix lr-lb dnat with multiple distributed gateway ports #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dceara
reviewed
Dec 20, 2023
northd/northd.c
Outdated
| est_match_p = xasprintf("%s && is_chassis_resident(%s)", | ||
| est_match, | ||
| od->l3dgw_ports[0]->cr_port->json_key); | ||
| if (od->n_l3dgw_ports > 1) { |
There was a problem hiding this comment.
What if the VIP is not in any of the LRP's subnets?
There was a problem hiding this comment.
Also, we probably need some tests to ensure this behavior doesn't change by accident in the future.
|
Never mind, I missed the sign off in the commit log but it's already there. Sorry for the noise. |
Signed-off-by: zcq98 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
zcq98
force-pushed
the
branch-22.12-bugfix
branch
from
62a650b
to
1e12432
Compare
|
hi @dceara,could you help review this ? |
|
Please target the |
dceara
requested changes
Jan 3, 2024
| static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1); | ||
| VLOG_WARN_RL(&rl, | ||
| "No matched LRP's subnet for VIP %s", | ||
| lb_vip->vip_str); |
There was a problem hiding this comment.
Is your intention to log when no GW port has a subnet matching the VIP? If so, this will log for every port that doesn't match the VIP and that seems wrong to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#222
is_chassis_resident and output in “lr_out_undnat” is not set correctly when there are multiple gw ports.
When lr has multiple gw ports, LB VIP should determine is_chassis_resident and outport based on the LRP's subnet to which it belongs.If there is no matching subnet, l3dgw_ports[0] will be used by default.