[php-di v7] AnnotationBasedAutowiring with additional options for performance tweaks #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Detected deprecations in use: - Rule "braces" is deprecated. Use "single_space_around_construct", "control_structure_braces", "control_structure_continuation_position", "declare_parentheses", "no_multiple_statements_per_line", "curly_braces_position", "statement_indentation" and "no_extra_blank_lines" instead. 2. Detected deprecations in use: - Rule "curly_braces_position" is deprecated. Use "braces_position" instead.
partikus
force-pushed
the
feature/php-di-7-annotations-autowiring-options
branch
2 times, most recently
from
1a859b4
to
40b4b87
Compare
|
I am not sure if this is still necessary - if performance differences are significant when disabling reading attributes - since now they are, in fact, attributes, and not custom phpdoc annotations - so the whole overhead of reading annotations is gone anyway. 🤔 |
|
I suppose it won't do any harm, and could only make it perform better while skipping making reflections and reading properties and methods when not necessary, but it would be nice to have a glimpse of what's the difference in performance now by running a perf test |
…ions feat: php-cs-fixer - removing deprecations
- adds possibility to disable features which are not used - useAnnotations(boolean) toggle on autowire() helper to enable/disable reading annotations on specific definitions
partikus
force-pushed
the
feature/php-di-7-annotations-autowiring-options
branch
from
40b4b87
to
55a5e10
Compare
|
@partikus could you add the performance test results and conclusions in a comment here, for the record, and close it, when you have some time, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version compatible with PHP ^8.0 as a successor of #4