forked from PHP-DI/PHP-DI
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[php-di v7] Service Locator #25
Open
partikus
wants to merge
5
commits into
feature/php-di-7-annotations-autowiring-options
Choose a base branch
from
feature/php-di-7-service-locator
base: feature/php-di-7-annotations-autowiring-options
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[php-di v7] Service Locator #25
partikus
wants to merge
5
commits into
feature/php-di-7-annotations-autowiring-options
from
feature/php-di-7-service-locator
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partikus
force-pushed
the
feature/php-di-7-service-locator
branch
from
January 10, 2024 12:35
2208f44
to
13a4b40
Compare
partikus
force-pushed
the
feature/php-di-7-service-locator
branch
3 times, most recently
from
January 10, 2024 12:49
aab1878
to
8031d21
Compare
partikus
force-pushed
the
feature/php-di-7-annotations-autowiring-options
branch
from
January 10, 2024 12:51
1a859b4
to
40b4b87
Compare
partikus
force-pushed
the
feature/php-di-7-service-locator
branch
from
January 10, 2024 12:51
8031d21
to
87ad7d4
Compare
partikus
force-pushed
the
feature/php-di-7-annotations-autowiring-options
branch
from
January 11, 2024 11:08
40b4b87
to
55a5e10
Compare
partikus
force-pushed
the
feature/php-di-7-service-locator
branch
from
January 11, 2024 11:10
87ad7d4
to
987e5bd
Compare
partikus
force-pushed
the
feature/php-di-7-service-locator
branch
from
January 30, 2024 15:38
6527923
to
fe94f5d
Compare
partikus
force-pushed
the
feature/php-di-7-service-locator
branch
from
January 30, 2024 15:49
fe94f5d
to
4395f1c
Compare
falkenhawk
reviewed
Jan 30, 2024
src/Definition/Reference.php
Outdated
* @var string|null name of an entry - holder of a definition requesting this entry | ||
*/ | ||
private ?string $requestingName = null, | ||
private ?ServiceLocatorDefinition $serviceLocatorDefinition = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this from constructor parameters, this should not be altered from outside. Ref: https://github.com/ovos/PHP-DI/pull/7/files#diff-addce6eaa59f011f6a80f000d9b021f007d8410be8044e3a747a6aa93ac54053R55
falkenhawk
changed the title
php8-mod: service locator feat
[php-di v7] Service Locator
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up - Service Locator introduced before by @falkenhawk in #7
copied from #7
ServiceLocator
note:
Reference
instance)Usage: