Feature/apiofboardsboardsectionstasks #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: code identation and boards crud
owaisali01
commented
Mar 1, 2023
| @@ -0,0 +1,2 @@ | |||
| module Api::V1::AssignedTasksHelper | |||
There was a problem hiding this comment.
Delete api/v1 folder from helpers
app/controllers/boards_controller.rb
Outdated
| redirect_to root_path | ||
| else | ||
| render :new | ||
| respond_to do |format| |
There was a problem hiding this comment.
Move respond_to inside if condition
owaisali01
commented
Mar 1, 2023
|
|
||
| def create | ||
| @board_section = @board.board_sections.build(board_section_params) | ||
| respond_to do |format| |
There was a problem hiding this comment.
Move respond_to inside if
| def show; end | ||
|
|
||
| def create | ||
| @comment = Comment.new(comment_params) |
There was a problem hiding this comment.
Replace Comment.new with @task.comments.new
|
|
||
| def create | ||
| @comment = Comment.new(comment_params) | ||
| respond_to do |format| |
| class DocumentsController < ApplicationController | ||
| before_action :set_document_object, only: %i[show edit update delete] | ||
|
|
||
| def index |
| @documents = Document.all | ||
| end | ||
|
|
||
| def new |
app/views/boards/_document.html.erb
Outdated
| @@ -0,0 +1,24 @@ | |||
| <div class="wrapper"> | |||
There was a problem hiding this comment.
Move this partial to documents folder
app/views/boards/_document.html.erb
Outdated
| </div> | ||
| <div class="col ps-0"> | ||
| <a href="javascript:void(0);" class="text-muted fw-bold"><%= document&.file_file_name%></a> | ||
| <p class="mb-0"><%= FriendlyNumbers.number_to_human_size(document.file_file_size) %></p> |
There was a problem hiding this comment.
Move this logic to document helper
app/views/boards/_results.html.erb
Outdated
| @@ -0,0 +1,3 @@ | |||
| <% board_sections&.each do |board_section |%> | |||
There was a problem hiding this comment.
Rename this partial to board_sections
app/views/boards/_results.html.erb
Outdated
| @@ -0,0 +1,3 @@ | |||
| <% board_sections&.each do |board_section |%> | |||
| <%= render :partial => 'boards/board_section', locals: {board_section: board_section, board: board} %> | |||
There was a problem hiding this comment.
Move it to board_sections folder
| @@ -0,0 +1,2 @@ | |||
| $('#blogpost-table').hide(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api of boards, boardsections, tasks, assign tasks to users with nested routes