Removed unnecessary dynamic_casts

owasp-modsecurity · Aug 8, 2024 · 18378c1 · 18378c1
1 parent a23e88f
commit 18378c1
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/src/rule_with_actions.cc b/src/rule_with_actions.cc
@@ -213,7 +213,7 @@ void RuleWithActions::executeActionsIndependentOfChainedRuleResult(Transaction *
         if (m_ruleId != b.first) {
             continue;
         }
-        actions::Action *a = dynamic_cast<actions::Action*>(b.second.get());
+        actions::Action *a = b.second.get();
         if (a->isDisruptive() == true && *a->m_name.get() == "block") {
             ms_dbg_a(trans, 9, "Rule contains a `block' action");
                 *containsBlock = true;
@@ -266,7 +266,7 @@ void RuleWithActions::executeActionsAfterFullMatch(Transaction *trans,
         if (m_ruleId != b.first) {
             continue;
         }
-        actions::Action *a = dynamic_cast<actions::Action*>(b.second.get());
+        actions::Action *a = b.second.get();
         executeAction(trans, containsBlock, ruleMessage, a, false);
         disruptiveAlreadyExecuted = true;
     }
@@ -394,8 +394,7 @@ void RuleWithActions::executeTransformations(
 
     for (Transformation *a : m_transformations) {
         if (none == 0) {
-            Transformation *t = dynamic_cast<Transformation *>(a);
-            executeTransformation(t, &value, trans, &ret, &path,
+            executeTransformation(a, &value, trans, &ret, &path,
                 &transformations);
         }
         if (a->m_isNone) {
@@ -423,8 +422,7 @@ void RuleWithActions::executeTransformations(
         }
         Transformation *a = dynamic_cast<Transformation*>(b.second.get());
         if (none == 0) {
-            Transformation *t = dynamic_cast<Transformation *>(a);
-            executeTransformation(t, &value, trans, &ret, &path,
+            executeTransformation(a, &value, trans, &ret, &path,
                 &transformations);
         }
         if (a->m_isNone) {
@@ -479,7 +477,7 @@ std::vector<actions::Action *> RuleWithActions::getActionsByName(const std::stri
         if (m_ruleId != b.first) {
             continue;
         }
-        actions::Action *z = dynamic_cast<actions::Action*>(b.second.get());
+        actions::Action *z = b.second.get();
         if (*z->m_name.get() == name) {
             ret.push_back(z);
         }
@@ -489,7 +487,7 @@ std::vector<actions::Action *> RuleWithActions::getActionsByName(const std::stri
         if (m_ruleId != b.first) {
             continue;
         }
-        actions::Action *z = dynamic_cast<actions::Action*>(b.second.get());
+        actions::Action *z = b.second.get();
         if (*z->m_name.get() == name) {
             ret.push_back(z);
         }