feat(api) new function: set hostname #3203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR adds a new feature which creates and sets the inside
m_requestHostName
variable, what used to fill the[hostname]
in the log.The PR provides a new API method:
Transaction::setHostName(const std::string& hostname)
. If the method is not called during the transaction, then the variable contains the server IP address (no changes). Only the application controls this method.There is a
C
function too:msc_set_request_hostname(const unsigned char * hostname)
;why
Currently,
[hostname]
contains the IP address of the server, which is not useful at all.references
See discussion #3200.