Lua::run: Move logging of str parameter to higher log level.
#3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frozenice
referenced
this pull request
Aug 26, 2024
pass FILES_TMPNAMES variable to lua engine Fixed Lua engine should also be aware of the variable and pass it to the target lua script main function
|
|
Hi @frozenice, thanks for your first PR! I would wait for 1-2 days if anyone wants to comment this PR. But it's good to me so if there won't be any remarks I'll merge this soon. |
|
Okay, no other feedback, merging now - thanks again! |
airween
added a commit
to airween/ModSecurity
that referenced
this pull request
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This silences a spammy debug log output.
why
When running with the debug log enabled, it spams a useless line for every request, when using a Lua script. It can't be disabled / filtered, because it's logged with the lowest level.
I don't know if 9 is the appropriate level. Alternatively this line could be removed altogether.
references
The line in question was introduced in Nov 2019.