Move id_log() to msc_util to fix unit tests; it is declared on msc_ut… #3265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous move of id_log() from re.c to apache2_config.c broke running the unit tests. The binary msc_test does not have apache2_config.c as a dependency in tests/Makefile so when linking you get an undefined symbol. And if you add apache2_config.c to the msc_test dependencies, even more undefined symbols now needed by apache2_config.c show up.
Since id_log() is already declared in msc_util.h, it seems right to move it to msc_util.c. And indeed this fixes the problem.